Skip to content

Commit

Permalink
[vpj][all] Create a new module for offline components to reduce leaka…
Browse files Browse the repository at this point in the history
…ge (#1205)

Recently, we moved some shared classes into "venice-common" to share common functionality. To do this, we added "hadoop-common" library into "venice-common". However, this leaks "hadoop-common" into online components too which is not desired. Moved these classes into a "venice-hadoop-common" package.
  • Loading branch information
nisargthakkar authored Sep 28, 2024
1 parent c694d96 commit b932806
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 6 deletions.
2 changes: 2 additions & 0 deletions clients/venice-push-job/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ dependencies {
exclude module: ':internal:alpini'
}

implementation project(':internal:venice-hadoop-common')

implementation (libraries.avro) {
exclude group: 'org.mortbay.jetty' // jetty 6 conflicts with spark-java used in controller api
}
Expand Down
6 changes: 0 additions & 6 deletions internal/venice-common/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,6 @@ dependencies {
exclude group: 'com.linkedin.container', module: 'container-eventbus-factory' // Keeping' it clean.
}

implementation (libraries.hadoopCommon) {
// Exclude transitive dependency
exclude group: 'org.apache.avro'
exclude group: 'javax.servlet'
}

implementation project(':clients:venice-thin-client')

implementation libraries.avroUtilCompatHelper
Expand Down
12 changes: 12 additions & 0 deletions internal/venice-hadoop-common/build.gradle
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
dependencies {
implementation project(':internal:venice-common')
implementation libraries.log4j2api
implementation (libraries.hadoopCommon) {
// Exclude transitive dependency
exclude group: 'org.apache.avro'
exclude group: 'javax.servlet'
}

testImplementation platform('org.junit:junit-bom:5.9.1')
testImplementation 'org.junit.jupiter:junit-jupiter'
}
1 change: 1 addition & 0 deletions settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ include 'services:venice-standalone'
include 'internal:venice-avro-compatibility-test'
include 'internal:venice-client-common'
include 'internal:venice-common'
include 'internal:venice-hadoop-common'
include 'internal:venice-jdk-compatibility-test'
include 'internal:venice-test-common'

Expand Down

0 comments on commit b932806

Please sign in to comment.