Merge pull request #75 from lineupjs/release/v2.5.1

Release v2.5.1
lineupjs · Jan 21, 2024 · 6f9e346 · 6f9e346
2 parents 5350854 + cc4c036
commit 6f9e346
Show file tree

Hide file tree

Showing 26 changed files with 6,722 additions and 6,286 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -1,15 +1,17 @@
 name: ci
 
-on: [push]
+on:
+  - push
+  - pull_request
 
 jobs:
   build:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 20
       - run: npm i -g yarn
       - run: yarn config set checksumBehavior ignore
       - name: Cache Node.js modules

diff --git a/.github/workflows/create_release.yml b/.github/workflows/create_release.yml
@@ -31,7 +31,7 @@ jobs:
           echo -n "::set-output name=next_tag::"
           npm version --no-git-tag-version ${{ github.event.inputs.versionName }} --preid ${{ github.event.inputs.preid }}
       - name: Create pull request into main
-        uses: peter-evans/create-pull-request@v4
+        uses: peter-evans/create-pull-request@v5
         with:
           branch: release/${{ steps.version.outputs.next_tag }}
           commit-message: 'chore: release ${{ steps.version.outputs.next_tag }}'

diff --git a/.github/workflows/release_main.yml b/.github/workflows/release_main.yml
@@ -19,9 +19,9 @@ jobs:
     steps:
       - name: Check out code
         uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 20
       - name: Extract version
         id: extract_version
         run: |
@@ -52,9 +52,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 20
       - run: npm i -g yarn
       - run: yarn config set checksumBehavior ignore
       - name: Cache Node.js modules

diff --git a/.stylelintrc b/.stylelintrc
@@ -4,13 +4,9 @@
     "stylelint-config-standard-scss"
   ],
   "rules": {
-    "string-quotes": "single",
     "no-descending-specificity": null,
-    "value-list-comma-newline-after": null,
-    "declaration-colon-newline-after": null,
     "at-rule-no-unknown": null,
     "at-rule-empty-line-before": null,
-    "block-closing-brace-newline-after": null,
     "selector-id-pattern": null,
     "scss/at-rule-no-unknown": true,
     "scss/no-global-function-names": null,
@@ -21,7 +17,6 @@
     "scss/at-function-pattern": null,
     "scss/at-if-closing-brace-newline-after": "always-last-in-chain",
     "scss/at-if-closing-brace-space-after": "always-intermediate",
-    "scss/at-import-no-partial-leading-underscore": true,
     "scss/at-import-partial-extension-blacklist": null,
     "scss/at-import-partial-extension-whitelist": null,
     "scss/at-mixin-argumentless-call-parentheses": "always",

diff --git a/.yarn/releases/yarn-3.2.2.cjs b/.yarn/releases/yarn-3.2.2.cjs
diff --git a/.yarn/releases/yarn-4.0.2.cjs b/.yarn/releases/yarn-4.0.2.cjs
diff --git a/.yarnrc.yml b/.yarnrc.yml
@@ -1,9 +1 @@
-packageExtensions:
-  eslint-config-airbnb-typescript@*:
-    dependencies:
-      eslint-config-airbnb-base: "*"
-  eslint-module-utils@*:
-    dependencies:
-      eslint-import-resolver-node: "*"
-
-yarnPath: .yarn/releases/yarn-3.2.2.cjs
+yarnPath: .yarn/releases/yarn-4.0.2.cjs
diff --git a/demo/cell.html b/demo/cell.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

diff --git a/demo/frozen.html b/demo/frozen.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

diff --git a/demo/index.html b/demo/index.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

diff --git a/demo/table.html b/demo/table.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head lang="en">
     <meta charset="UTF-8" />

diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "lineupengine",
   "description": "a fast engine for rendering large tables consisting of rows, rows+columns, multiple rows+columns instances.",
   "homepage": "https://lineupengine.js.org",
-  "version": "2.5.0",
+  "version": "2.5.1",
   "author": {
     "name": "Samuel Gratzl",
     "email": "[email protected]",
@@ -61,49 +61,50 @@
     "prepare": "echo 'dummy prepare since prepack has no dev dependencies'",
     "prepack": "npm run clean && npm run compile && npm run build"
   },
+  "resolutions": {
+    "@typescript-eslint/eslint-plugin": "^6.19.0",
+    "@typescript-eslint/parser": "^6.19.0"
+  },
   "devDependencies": {
-    "@types/jest": "^28.1.6",
-    "@typescript-eslint/eslint-plugin": "^5.30.7",
-    "@typescript-eslint/parser": "^5.30.7",
-    "@yarnpkg/sdks": "^2.6.2",
-    "css-loader": "^6.7.1",
-    "eslint": "^8.20.0",
-    "eslint-config-airbnb-typescript": "^17.0.0",
-    "eslint-config-prettier": "^8.5.0",
+    "@types/jest": "^29.5.11",
+    "@typescript-eslint/eslint-plugin": "^6.19.0",
+    "@typescript-eslint/parser": "^6.19.0",
+    "@yarnpkg/sdks": "^3.1.0",
+    "css-loader": "^6.9.1",
+    "eslint": "^8.56.0",
+    "eslint-config-airbnb-typescript": "^17.1.0",
+    "eslint-config-prettier": "^9.1.0",
     "eslint-config-react-app": "^7.0.1",
     "eslint-plugin-flowtype": "^8.0.3",
-    "eslint-plugin-import": "^2.26.0",
-    "eslint-plugin-jsx-a11y": "^6.6.1",
-    "eslint-plugin-prettier": "^4.2.1",
-    "eslint-plugin-react": "^7.30.1",
+    "eslint-plugin-import": "^2.29.1",
+    "eslint-plugin-jsx-a11y": "^6.8.0",
+    "eslint-plugin-prettier": "^5.1.3",
+    "eslint-plugin-react": "^7.33.2",
     "eslint-plugin-react-hooks": "^4.6.0",
-    "fork-ts-checker-webpack-plugin": "^7.2.13",
-    "jest": "^28.1.3",
-    "jest-environment-jsdom": "^28.1.3",
-    "mini-css-extract-plugin": "^2.6.1",
-    "mkdirp": "^1.0.4",
-    "postcss": "^8.4.14",
-    "prettier": "^2.7.1",
-    "rimraf": "^3.0.2",
-    "sass": "^1.53.0",
-    "sass-loader": "^13.0.2",
-    "style-loader": "^3.3.1",
-    "stylelint": "^14.9.1",
-    "stylelint-config-prettier-scss": "^0.0.1",
-    "stylelint-config-standard-scss": "^5.0.0",
-    "stylelint-prettier": "^2.0.0",
-    "stylelint-scss": "^4.3.0",
-    "thread-loader": "^3.0.4",
-    "ts-jest": "^28.0.7",
-    "ts-loader": "^9.3.1",
-    "typedoc": "^0.23.8",
-    "typescript": "^4.7.4",
-    "webpack": "^5.73.0",
-    "webpack-cli": "^4.10.0",
-    "webpack-dev-server": "^4.9.3"
-  },
-  "dependencies": {
-    "tslib": "^2.4.0"
+    "fork-ts-checker-webpack-plugin": "^9.0.2",
+    "jest": "^29.7.0",
+    "jest-environment-jsdom": "^29.7.0",
+    "mini-css-extract-plugin": "^2.7.7",
+    "mkdirp": "^3.0.1",
+    "postcss": "^8.4.33",
+    "prettier": "^3.2.4",
+    "rimraf": "^5.0.5",
+    "sass": "^1.70.0",
+    "sass-loader": "^14.0.0",
+    "style-loader": "^3.3.4",
+    "stylelint": "^16.2.0",
+    "stylelint-config-prettier-scss": "^1.0.0",
+    "stylelint-config-standard-scss": "^13.0.0",
+    "stylelint-prettier": "^5.0.0",
+    "stylelint-scss": "^6.1.0",
+    "thread-loader": "^4.0.2",
+    "ts-jest": "^29.1.1",
+    "ts-loader": "^9.5.1",
+    "typedoc": "^0.25.7",
+    "typescript": "^5.3.3",
+    "webpack": "^5.89.0",
+    "webpack-cli": "^5.1.4",
+    "webpack-dev-server": "^4.15.1"
   },
-  "packageManager": "yarn@3.2.2"
+  "packageManager": "yarn@4.0.2"
 }
diff --git a/src/ACellRenderer.ts b/src/ACellRenderer.ts
@@ -19,7 +19,11 @@ export abstract class ACellRenderer<T extends IColumn> extends ARowRenderer {
 
   private readonly cell: ACellAdapter<T>;
 
-  constructor(protected readonly root: HTMLElement, htmlId: string, options: Partial<IRowRendererOptions> = {}) {
+  constructor(
+    protected readonly root: HTMLElement,
+    htmlId: string,
+    options: Partial<IRowRendererOptions> = {}
+  ) {
     // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
     super(setTemplate(root, htmlId).querySelector<HTMLElement>('main > article')!, options);
     root.classList.add(cssClass(), 'lineup-engine');

diff --git a/src/ARowRenderer.ts b/src/ARowRenderer.ts
@@ -120,7 +120,10 @@ export abstract class ARowRenderer {
     viewportOversize: 200,
   };
 
-  constructor(protected readonly body: HTMLElement, options: Partial<IRowRendererOptions> = {}) {
+  constructor(
+    protected readonly body: HTMLElement,
+    options: Partial<IRowRendererOptions> = {}
+  ) {
     this.adapter = this.createAdapter();
     Object.assign(this.options, options);
     this.mixins = this.options.mixins.map((MixinClass) => new MixinClass(this.adapter));

diff --git a/src/abortAble.ts b/src/abortAble.ts
@@ -129,7 +129,7 @@ export function abortAbleAll<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10>(
     T7 | IAAP<T7>,
     T8 | IAAP<T8>,
     T9 | IAAP<T9>,
-    T10 | IAAP<T10>
+    T10 | IAAP<T10>,
   ]
 ): IAAP<[T1, T2, T3, T4, T5, T6, T7, T8, T9, T10]>;
 export function abortAbleAll<T1, T2, T3, T4, T5, T6, T7, T8, T9>(
@@ -142,7 +142,7 @@ export function abortAbleAll<T1, T2, T3, T4, T5, T6, T7, T8, T9>(
     T6 | IAAP<T6>,
     T7 | IAAP<T7>,
     T8 | IAAP<T8>,
-    T9 | IAAP<T9>
+    T9 | IAAP<T9>,
   ]
 ): IAAP<[T1, T2, T3, T4, T5, T6, T7, T8, T9]>;
 export function abortAbleAll<T1, T2, T3, T4, T5, T6, T7, T8>(
@@ -154,7 +154,7 @@ export function abortAbleAll<T1, T2, T3, T4, T5, T6, T7, T8>(
     T5 | IAAP<T5>,
     T6 | IAAP<T6>,
     T7 | IAAP<T7>,
-    T8 | IAAP<T8>
+    T8 | IAAP<T8>,
   ]
 ): IAAP<[T1, T2, T3, T4, T5, T6, T7, T8]>;
 export function abortAbleAll<T1, T2, T3, T4, T5, T6, T7>(

diff --git a/src/animation/KeyFinder.ts b/src/animation/KeyFinder.ts
@@ -15,7 +15,10 @@ export default class KeyFinder {
    * @param {IExceptionContext} context context to use
    * @param {(rowIndex: number) => string} key key function
    */
-  constructor(public readonly context: IExceptionContext, public readonly key: (rowIndex: number) => string) {
+  constructor(
+    public readonly context: IExceptionContext,
+    public readonly key: (rowIndex: number) => string
+  ) {
     this.context.exceptions.forEach((e) => {
       this.cache[e.index] = e.y;
       this.key2index.set(key(e.index), e.index);

diff --git a/src/logic.ts b/src/logic.ts
@@ -21,7 +21,11 @@ export interface IRowHeightException {
 }
 
 class RowHeightException implements IRowHeightException {
-  constructor(public readonly index: number, public readonly y: number, public readonly height: number) {}
+  constructor(
+    public readonly index: number,
+    public readonly y: number,
+    public readonly height: number
+  ) {}
 
   get y2() {
     return this.y + this.height;

diff --git a/src/mixin/PrefetchMixin.ts b/src/mixin/PrefetchMixin.ts
@@ -33,7 +33,10 @@ export default class PrefetchMixin implements IMixin {
     delay: 200,
   };
 
-  constructor(private readonly adapter: IMixinAdapter, options?: Partial<IPrefetchRendererOptions>) {
+  constructor(
+    private readonly adapter: IMixinAdapter,
+    options?: Partial<IPrefetchRendererOptions>
+  ) {
     Object.assign(this.options, options);
     return this;
   }

diff --git a/src/styles/_animation.scss b/src/styles/_animation.scss
@@ -32,7 +32,9 @@
     > main.#{$engine_css_prefix}-scrolling {
       background-image: $engine_loading_static_image, $engine_loading_static_image;
       background-repeat: repeat-x;
-      background-position: top 10px left, bottom 30px left;
+      background-position:
+        top 10px left,
+        bottom 30px left;
       position: relative;
     }
   }

diff --git a/src/styles/_mixins.scss b/src/styles/_mixins.scss
@@ -1,8 +1,11 @@
 /* stylelint-disable value-list-comma-newline-after */
 @mixin collapsing-row-border($border-width, $border-color) {
   // use box-shadow to create collapsing border (@see https://stackoverflow.com/a/28807765)
-  box-shadow: $border-width 0 0 0 $border-color, 0 $border-width 0 0 $border-color,
-    $border-width $border-width 0 0 $border-color /* Just to fix the corner */, $border-width 0 0 0 $border-color inset,
+  box-shadow:
+    $border-width 0 0 0 $border-color,
+    0 $border-width 0 0 $border-color,
+    $border-width $border-width 0 0 $border-color /* Just to fix the corner */,
+    $border-width 0 0 0 $border-color inset,
     0 0 0 $border-width $border-color;
 }
 /* stylelint-enable value-list-comma-newline-after */
diff --git a/src/table/MultiTableRowRenderer.ts b/src/table/MultiTableRowRenderer.ts
@@ -82,7 +82,11 @@ export default class MultiTableRowRenderer {
     minScrollDelta: 30,
   };
 
-  constructor(public readonly node: HTMLElement, htmlId: string, options: Partial<IMultiTableRowRendererOptions> = {}) {
+  constructor(
+    public readonly node: HTMLElement,
+    htmlId: string,
+    options: Partial<IMultiTableRowRendererOptions> = {}
+  ) {
     Object.assign(this.options, options);
     const cleanHTMLId = htmlId.startsWith('#') ? htmlId.slice(1) : htmlId;
     // eslint-disable-next-line no-param-reassign

diff --git a/src/table/internal/ACellAdapter.ts b/src/table/internal/ACellAdapter.ts
@@ -262,12 +262,12 @@ export abstract class ACellAdapter<T extends IColumn> {
     row: number,
     column: number,
     columns: T[]
-  ): { item: HTMLElement; ready: IAbortAblePromise<void> | void } {
+  ): { item: HTMLElement; ready: IAbortAblePromise<void> | undefined } {
     const pool = this.cellPool[column];
     const columnObj = columns[column];
 
     let item: HTMLElement;
-    let ready: IAbortAblePromise<void> | void;
+    let ready: IAbortAblePromise<void> | undefined = undefined;
     const pooled = pool.pop();
 
     const r = pooled

diff --git a/tests/logic.spec.ts b/tests/logic.spec.ts
@@ -25,15 +25,18 @@ describe('logic', () => {
   function expectExceptionLookups(ex: IRowHeightExceptionLookup, ...indexAndHeight: number[]) {
     expect(indexAndHeight.length % 2).toBe(0); //even
 
-    const checks = indexAndHeight.reduce((acc, indexOrHeight, i) => {
-      const isIndex = i % 2 === 0;
-      if (isIndex) {
-        acc.push({ index: indexOrHeight, height: 0 });
-      } else {
-        acc[acc.length - 1].height = indexOrHeight;
-      }
-      return acc;
-    }, [] as { index: number; height: number }[]);
+    const checks = indexAndHeight.reduce(
+      (acc, indexOrHeight, i) => {
+        const isIndex = i % 2 === 0;
+        if (isIndex) {
+          acc.push({ index: indexOrHeight, height: 0 });
+        } else {
+          acc[acc.length - 1].height = indexOrHeight;
+        }
+        return acc;
+      },
+      [] as { index: number; height: number }[]
+    );
 
     expect(ex.size).toBe(checks.length);
 

diff --git a/tsconfig.dev.json b/tsconfig.dev.json
@@ -1,7 +1,7 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "target": "es6"
+    "target": "ES2022"
   },
   "typedocOptions": {
     "name": "Lineupengine",