Add an option for open (permissionless) multi-leader rounds. #3168
+116
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afck
requested review from
ma2bd,
christos-h,
bart-linera and
deuszx
and removed request for
deuszx
bart-linera
approved these changes
Jan 23, 2025
| @@ -200,6 +200,7 @@ Open (i.e. activate) a new multi-owner chain deriving the UID from an existing o | |||
|
|
|||
| If they are specified there must be exactly one weight for each owner. If no weights are given, every owner will have weight 100. | |||
| * `--multi-leader-rounds <MULTI_LEADER_ROUNDS>` — The number of rounds in which every owner can propose blocks, i.e. the first round number in which only a single designated leader is allowed to propose blocks | |||
| * `--open-multi-leader-rounds` — Whether the multi-leader rounds are unrestricted, i.e. not limited to chain owners. This should only be `true` on chains with restrictive application permissions and an application-based mechanism to select block proposers | |||
There was a problem hiding this comment.
Should we add some mechanism that would disallow setting this on chains without restrictive application permissions? (Not necessarily now, but maybe a nice to have in the future?)
There was a problem hiding this comment.
I don't think so: Even if you do set app permissions, we can't control what the app does—it might still allow anyone to propose blocks.
So I think we just need to guard against spam on the validator side, and otherwise the rule is always that your we only guarantee safety; bad chain owners or chain configs can brick a chain.
afck
added a commit
that referenced
this pull request
Jan 23, 2025
## Motivation #3168 and #3169 were merged without rebasing on each other, breaking the build. ## Proposal Fix the broken line. ## Test Plan With this and #3171 CI should work again. ## Release Plan - Nothing to do / These changes follow the usual release cycle. ## Links - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For #3162, some chains need to be "permissionless", i.e. admit any signer as a block proposer, as far as the chain manager is concerned.
Proposal
Add an
open_multi_leader_roundsoption. If it istrue, the multi-leader rounds are not restricted to the chain owners anymore. (All other round types still are restricted as usual.)Test Plan
A test was added.
Release Plan
Links