Move start-lineman into a grunt task

[tandrewnichols]

@searls Is there any reason not to do start-lineman in a task rather than a beforeAll (ish). We're using it in our code that way, and it seems to work better because it always happens only once, and it always happens only before the specs are run. Additionally, this would solve (well, in cases where a new lineman process is started) #6.

This isn't quite ready to merge because obviously, the spec-browser task needs to also "include" the start-lineman task. In our code we just define a task that runs both startLineman and specBrowser, but I'm imaging that that might be more difficult here. Is there a good way to do that?

[searls]

I don't think there's an issue with this technically, but it would be problematic for a grunt task to start lineman and keep it running indefinitely, right? I tend to think of tasks as discrete, idempotent things that can be run and which stop having side effects after they have completed.

On Tue, Apr 22, 2014 at 8:49 AM, Andrew Nichols [email protected]
wrote:

@searls Is there any reason not to do start-lineman in a task rather than a beforeAll (ish). We're using it in our code that way, and it seems to work better because it always happens only once, and it always happens only before the specs are run. Additionally, this would solve (well, in cases where a new lineman process is started) #6.
This isn't quite ready to merge because obviously, the spec-browser task needs to also "include" the start-lineman task. In our code we just define a task that runs both startLineman and specBrowser, but I'm imaging that that might be more difficult here. Is there a good way to do that?
You can merge this Pull Request by running:
git pull https://github.com/mantacode/lineman-spec-browser start-server-task
Or you can view, comment on it, or merge it online at:
#10
-- Commit Summary --

• Move start-lineman into a grunt task
  -- File Changes --
  M config/plugins/spec-browser.coffee (1)
  D helpers/start-lineman.coffee (22)
  A tasks/start-lineman.coffee (36)
  -- Patch Links --
  https://github.com/linemanjs/lineman-spec-browser/pull/10.patch
  https://github.com/linemanjs/lineman-spec-browser/pull/10.diff

  Reply to this email directly or view it on GitHub:
  Move start-lineman into a grunt task #10

[tandrewnichols]

If it starts lineman, it kills it on process.exit.

[searls]

Hmm. I need to review this and I won't have a chance for a little while. I've filed this away

On Tue, Apr 22, 2014 at 9:29 AM, Andrew Nichols [email protected]
wrote:

If it starts lineman, it kills it on process.exit.

Reply to this email directly or view it on GitHub:
#10 (comment)