Stop using __LINE_BOT_SDK_PYTHON_VERSION__ #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
output in CI |
Yang-33
commented
Nov 21, 2024
Comment on lines
+34
to
+38
| if [ "${{ github.event_name }}" == "workflow_dispatch" ]; then | ||
| VERSION=${{ github.event.inputs.version }} | ||
| else | ||
| VERSION=${{ github.event.release.tag_name }} | ||
| fi |
There was a problem hiding this comment.
(for unexpected failure)
eucyt
reviewed
Nov 25, 2024
eucyt
reviewed
Nov 25, 2024
Co-authored-by: Yuta Euchi <[email protected]>
Co-authored-by: Yuta Euchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string
__LINE_BOT_SDK_PYTHON_VERSION__is used inlinebot/__about__.pyto make it easier to replace with the new version at the time of release. However, this string is inappropriate as a version, so it needs to be replaced when testing locally... This is cumbersome for us, so this PR addresses that issue.At the time of release, the file that need to be updated will be directly modified anyway.
./tools/update_version.pywill handle this. Since 1 lines across 1 files need to be changed, the CI will fail if this condition is not met. Reviewers can verify that the version is changed locally, but it's up to them whether to do so.