Improve formatting #101
Improve formatting #101
Conversation
nirs
commented
Dec 5, 2024
•
nirs
commented
- Reformat long optins idiomatically
- Unify whitespace
This makes the table much nicer and easier to read. Signed-off-by: Nir Soffer <[email protected]>
nirs
changed the title
I did not notice, adding another commit. How about adding a clang-format file to auto format the code? And change to more common and readable style, like linux kernel style? It is hard to work with 2 space indent, and the code look too dense. |
The enum was added with 4 spaces by mistake, since we don't have auto format or editor config setup. Fix to 2 spaces. Signed-off-by: Nir Soffer <[email protected]>
|
@jandubois enum fixed now. |
| {"pidfile", required_argument, NULL, 'p'}, | ||
| {"help", no_argument, NULL, 'h'}, | ||
| {"version", no_argument, NULL, 'v'}, | ||
| {0, 0, 0, 0}, |
There was a problem hiding this comment.
We should use clang-format or something for maintaining the format.
Does clang-format or something support keeping this whitespacing?
There was a problem hiding this comment.
No idea but even if not having automatic formatting is better.
There was a problem hiding this comment.
All the default styles (LLVM, GNU, Google, Chromium, Microsoft, Mozilla, WebKit) destroy the nice table. Maybe there is an option to align tables, or to disable formatting of part of a file.
There was a problem hiding this comment.
I haven't tested it, but according to Disabling Formatting on a Piece of Code you can disable it for a block like this:
// clang-format off
const struct option longopts[] = {
{"socket-group", required_argument, NULL, CLI_OPT_SOCKET_GROUP},
{"vmnet-mode", required_argument, NULL, CLI_OPT_VMNET_MODE},
{"vmnet-interface", required_argument, NULL, CLI_OPT_VMNET_INTERFACE},
{"vmnet-gateway", required_argument, NULL, CLI_OPT_VMNET_GATEWAY},
{"vmnet-dhcp-end", required_argument, NULL, CLI_OPT_VMNET_DHCP_END},
{"vmnet-mask", required_argument, NULL, CLI_OPT_VMNET_MASK},
{"vmnet-interface-id", required_argument, NULL, CLI_OPT_VMNET_INTERFACE_ID},
{"vmnet-nat66-prefix", required_argument, NULL, CLI_OPT_VMNET_NAT66_PREFIX},
{"pidfile", required_argument, NULL, 'p'},
{"help", no_argument, NULL, 'h'},
{"version", no_argument, NULL, 'v'},
{0, 0, 0, 0},
};
// clang-format on
