multi: update log dep for sub-modules #9212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that the logging config "Disable" options and log type flags are all handled in one place. Other repo's can then re-use this nicely.
|
Demonstration of CI passing for this here |
guggero
approved these changes
Oct 24, 2024
| @@ -1,9 +1,11 @@ | |||
| module github.com/lightningnetwork/lnd/healthcheck | |||
|
|
|||
| go 1.19 | |||
| go 1.21 | |||
There was a problem hiding this comment.
Since we're touching all go sub modules of the project, should we also unify this? I mostly mean the location of the version (at the beginning of the file or after the require and replace blocks) as well as if we specify toolchain?
Looks like most files put the version toward the bottom for example (my preferred placement as well).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update btclog dep to v2 for sqldb, kvdb, healthcheck and tor modules.
Also move more logic into
NewDefaultLogHandlersso that other repos can re-use this method to apply the logger build tags.