-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: update log dep for sub-modules #9212
base: master
Are you sure you want to change the base?
Conversation
So that the logging config "Disable" options and log type flags are all handled in one place. Other repo's can then re-use this nicely.
Demonstration of CI passing for this here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM 🎉
@@ -1,9 +1,11 @@ | |||
module github.com/lightningnetwork/lnd/healthcheck | |||
|
|||
go 1.19 | |||
go 1.21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're touching all go sub modules of the project, should we also unify this? I mostly mean the location of the version (at the beginning of the file or after the require and replace blocks) as well as if we specify toolchain
?
Looks like most files put the version toward the bottom for example (my preferred placement as well).
Update btclog dep to v2 for sqldb, kvdb, healthcheck and tor modules.
Also move more logic into
NewDefaultLogHandlers
so that other repos can re-use this method to apply the logger build tags.