Ignore when first constructor parameter is dropped from Signature #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before Scala 2.12.9/2.13.1, the `Signature` attribute of an inner class constructor would also contain the first, synthetic parameter. This was fixed in scala/scala#7975, which course leads to mima warnings about inconsistent signatures. Since the descriptor remains the same, and the previous signature was wrong anyway (so anything relying on it can not have worked in the first place) this specific change can be safely ignored Tested with Akka HTTP, akka/akka-http#2655 (comment)
This was referenced Aug 21, 2019
dwijnand
reviewed
Aug 21, 2019
core/src/main/scala/com/typesafe/tools/mima/lib/analyze/method/MethodChecker.scala
Outdated
Show resolved
Hide resolved
|
Could revert all the filters added in #369 🎉 |
dwijnand
reviewed
Aug 21, 2019
core/src/main/scala/com/typesafe/tools/mima/lib/analyze/method/MethodChecker.scala
Outdated
Show resolved
Hide resolved
dwijnand
reviewed
Aug 22, 2019
core/src/main/scala/com/typesafe/tools/mima/lib/analyze/method/MethodChecker.scala
Show resolved
Hide resolved
dwijnand
deleted the
ignoreWhenFirstConstructorParameterIsDroppedInConstructor
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Scala 2.12.9/2.13.1, the
Signatureattribute of an inner classconstructor would also contain the first, synthetic parameter.
This was fixed in scala/scala#7975, which course leads
to mima warnings about inconsistent signatures. Since the descriptor remains
the same, and the previous signature was wrong anyway (so anything relying on
it can not have worked in the first place) this specific change can be safely
ignored
Tested with Akka HTTP, akka/akka-http#2655 (comment)