Test latest scala-library 2.12.9, analysed #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the method checker didn't take overloading into account, which means that the loss of a method overloading (which includes the loss of a static forwarder methods, when upgrading from Scala 2.12.7 to 2.12.8+) was reported as an "incompatible method type" problem or a "incompatible result type" problem. With this change these are now correctly reported as "direct missing method" problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #361 ("X has a different signature in current version").
Builds on #362 ("Removed overloads are missing, not incompatible").
These are all the problems in the 2.12.x series of scala-library, including all the currently reported incompatible signature problems - all of which are false-positives.
See #335 and #363 for some proposed enhancements to remove some cases of false positives.
The advice on
IncompatibleSignatureProblemis that it can false positive:ProblemFilters.exclude[IncompatibleSignatureProblem]("*")to filter them all out.