Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for worker bundling #306

Merged
merged 31 commits into from
Oct 3, 2021

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Oct 2, 2021

related to: #305

Before land:

  • ensure disabling sync fs access does not break main logic
  • ensure we don't trying to load els-addons in worker mode (import scripts not supported)
  • ensure we don't trying to use template-lint in worker mode, but we could explore bundling here: feat: bundle web-worker (nodeless) version of linter ember-template-lint/ember-template-lint#2120
  • add async fs tests
  • land light walkAsync version? (+ensure all calls is async)
  • figure out config option to get async-fs working in node
  • move _sendCommand implementation to server (project?) api

This Mr lands:

  • async fs provider
  • minimal draft async fs api
  • walkSync -> walkAsync replacement
  • async fs provider tests
  • sendCommand Server method
  • drops node 10 support
  • removes unneded deps
  • breaking: server options configuration
  • full fs async api support

@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #306 (dafbe28) into component-context-info-origin (16f5203) will increase coverage by 0.31%.
The diff coverage is 75.25%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           component-context-info-origin     #306      +/-   ##
=================================================================
+ Coverage                          68.82%   69.14%   +0.31%     
=================================================================
  Files                                 42       44       +2     
  Lines                               3474     3714     +240     
  Branches                             733      774      +41     
=================================================================
+ Hits                                2391     2568     +177     
- Misses                              1080     1144      +64     
+ Partials                               3        2       -1     
Impacted Files Coverage Δ
src/utils/addon-api.ts 61.53% <33.33%> (+1.05%) ⬆️
src/utils/fs-utils.ts 35.89% <35.89%> (ø)
src/project.ts 73.91% <45.45%> (-3.02%) ⬇️
src/template-linter.ts 52.29% <66.66%> (-0.60%) ⬇️
src/fs-provider.ts 82.14% <79.66%> (-7.52%) ⬇️
src/utils/walk-async.ts 85.04% <85.04%> (ø)
src/server.ts 64.86% <88.46%> (+0.40%) ⬆️
src/utils/layout-helpers.ts 91.86% <89.28%> (-0.10%) ⬇️
src/project-roots.ts 88.59% <100.00%> (ø)
src/start-server.ts 88.88% <100.00%> (+3.17%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16f5203...dafbe28. Read the comment docs.

@lifeart lifeart changed the title Upstream worker bundling deps worker bundling Oct 2, 2021
@lifeart lifeart changed the title worker bundling prepare for worker bundling Oct 3, 2021
@lifeart lifeart merged commit 851f23f into component-context-info-origin Oct 3, 2021
@lifeart lifeart deleted the upstream-worker-bundling-deps branch October 3, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant