Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up .info files #1797

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Clean up .info files #1797

wants to merge 3 commits into from

Conversation

Jarvik7
Copy link
Contributor

@Jarvik7 Jarvik7 commented Feb 21, 2024

This is primarily regarding the hashes for bioses.
Currently the hashes are all smashed into a single notes line, which is hard to parse programmatically, and even harder to visually confirm that it is complete (many bios are missing hashes)

This is the first step of an intended cleanup with the end goal of having hashes for all bios, and separately a programmatically generated .dat file for each platform to enable users to easily gather the required bios (and only the required bios) for their platform.

Roadmap is as follows but there should be nothing stopping the immediate commit of this PR.

Roadmap:

  1. Move hashes from notes line into separate firmware#_md5 or firmware#_sha1 lines for each bios definition
  2. Create python script to generate master system.dat from folder of .info files
  3. Add missing bios hashes and switch to sha1
  4. Create additional python script to generate a platform-specific system.dat, e.g. dat for bios needed on cores for PSV retroarch build. This will use platform recipes to select the .info files to use

Clean up by moving into an item under each firmware definition instead of all crammed into the notes.
@fpscan
Copy link
Collaborator

fpscan commented Feb 24, 2024

Can you also do the samething here: https://github.com/libretro/libretro-core-info

@zoltanvb
Copy link
Contributor

zoltanvb commented Mar 3, 2024

It does look more readable in the file, but this change with current RetroArch code will make the checksum values disappear from Information / Core Information after loading a core. Firmware checksums are not validated (at least not by RA, anyway, as far as I could check from https://github.com/libretro/RetroArch/blob/master/core_info.c ), but still this is a loss of information for the end user.

Note for anyone testing this, remove the core_info.cache file after updating .info files.

@RobLoach
Copy link
Member

Always a fan of more cleanup in these info files.

Move hashes from notes line into separate firmware#_md5 or firmware#_sha1 lines for each bios definition

Is this change supported by RetroArch currently? I haven't seen many .info files using this new format.

Can you also do the samething here: https://github.com/libretro/libretro-core-info

That's just a mirror of this, so likely best to handle it here first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants