Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ping example #477

Merged
merged 3 commits into from
Oct 24, 2024
Merged

added ping example #477

merged 3 commits into from
Oct 24, 2024

Conversation

mystical-prog
Copy link
Contributor

Ping Example

This PR includes the addition of a ping.py file under the examples dir, the current implementation of ping uses a server-client approach wherein a server will keep the stream open (till closed manually) and clients will complete their execution after they have received a pong response back from the server.

Issue #458

I am attaching images of logs obtained from server and client side execution below -
Screenshot from 2024-10-18 21-57-54
Screenshot from 2024-10-18 21-59-29
Screenshot from 2024-10-18 21-59-20

@mystical-prog
Copy link
Contributor Author

I have added the documentation for the ping usage example as well, let me know if there are any other changes necessary to be made @pacrob

Copy link
Member

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! As discussed, failing tests are unrelated.

@pacrob pacrob merged commit bcc7d25 into libp2p:main Oct 24, 2024
10 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants