Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency issues (and fastecdsa windows depencency) #380

Merged
merged 2 commits into from
Dec 23, 2019
Merged

Fix dependency issues (and fastecdsa windows depencency) #380

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1124fc8
add eth_utils
ShadowJonathan Dec 19, 2019
0b97f4d
remove eth_utils per PR request
ShadowJonathan Dec 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"ipython",
"setuptools>=36.2.0",
"tox>=3.13.2,<4.0.0",
"eth_utils",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need eth_utils here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the issue template, it's asked to run python -m eth_utils, it'll be useful to have that as a part of a default development suite.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's the typo in the issue template and we should fix it. IMO we shouldn't have eth_utils here.

],
}

Expand All @@ -43,6 +44,20 @@
+ extras_require["doc"]
)

fastecdsa = [
# No official fastecdsa==1.7.4,1.7.5 wheels for Windows, using a pypi package that includes
# the original library, but also windows-built wheels (32+64-bit) on those versions.
# Fixme: Remove section when fastecdsa has released a windows-compatible wheel
# (specifically: both win32 and win_amd64 targets)
# See the following issues for more information;
# https://github.com/libp2p/py-libp2p/issues/363
# https://github.com/AntonKueltz/fastecdsa/issues/11
"fastecdsa-any==1.7.5;sys_platform=='win32'",
# Wheels are provided for these platforms, or compiling one is minimally frustrating in a
# default python installation.
"fastecdsa==1.7.5;sys_platform!='win32'",
]


with open("./README.md") as readme:
long_description = readme.read()
Expand All @@ -67,7 +82,7 @@
# RTD system so we have to exclude these dependencies when we are in an RTD environment.
readthedocs_is_building = os.environ.get("READTHEDOCS", False)
if not readthedocs_is_building:
install_requires.append("fastecdsa==1.7.4")
install_requires.extend(fastecdsa)


setup(
Expand Down