Add support for network interfaces in mDNS configuration #3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue encountered on Android devices when using the [zeroconf] package, which results in the following error:
The root cause of this issue is that the zeroconf package fails to properly detect network interfaces on Android. To resolve this, I have implementation with anet, which includes a fix specifically targeting Android compatibility.
Additionally, a similar issue exists in the package github.com/multiformats/go-multiaddr, where it fails to handle network interfaces correctly on Android. I worked around this issue with the following commit:
8491a6c56a51cc4dec517388f4f044d939896984