Adding usage of git_create_remote_detached #755
Conversation
ralucas
force-pushed
the
remote-detached
branch
3 times, most recently
from
f61dc59 to
db7fcff
Compare
ralucas
changed the title
| } | ||
|
|
||
| func TestRemoteDetached_LsDetached(t *testing.T) { | ||
| r, _ := NewRemoteDetached(TestGitRepoUri) |
There was a problem hiding this comment.
| r, _ := NewRemoteDetached(TestGitRepoUri) | |
| remote, err := NewRemoteDetached(TestGitRepoUri) | |
| checkFatal(t, err) | |
| defer remote.Free() |
for consistency with other tests that create remotes (and to avoid memory leaks)
| return nil, MakeGitError(ret) | ||
| } | ||
|
|
||
| return &RemoteDetached{r: Remote{ptr: ptr}}, nil |
There was a problem hiding this comment.
would it be possible for this to return the *Remote directly? That way the RemoteDetached and the LsDetached shouldn't be needed, since callers can interact with the remote using the normal API, which will avoid having to implement more APIs on RemoteDetached that would only forward arguments to the underlying Remote. It's totally fine if the repo property is nil: it's just there to avoid the GC from deleting the Repository when the Remote is still around, but here it will be nil.
also, the finalizer for the Remote object must be set prior to returning to avoid memory leaks:
Lines 586 to 587 in 75708ee
This creates a
RemoteDetachedtype that is instantiable with a remote uri string. It has only one method,LsDetachedfor emulatinggit ls-remote <remote-uri>.The reason for this is that it looks like there is no other way to simply do a
git ls-remotetype request without creating a repository reference locally.Thank you for your time in reviewing this.