bug fix (set shell=False)

li-xin-yi · Mar 31, 2021 · ec95050 · ec95050
1 parent 83028da
commit ec95050
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/demo/big_news.pdf b/demo/big_news.pdf
diff --git a/examples/reports/2_feature_select.pdf b/examples/reports/2_feature_select.pdf
diff --git a/hkjournalist/journalist.py b/hkjournalist/journalist.py
@@ -220,7 +220,9 @@ def report(self, output_file='./final_report.pdf', beamer=True, theme='default',
         args_list += ['-o', final_file]
 
         # command = f'pandoc {beamer_command} {raw_file} {tex_command} {args_list} -s -o {final_file}'
-        proc = subprocess.run(args_list, shell=True, capture_output=True)
+
+        # shell=True sometimes leads to invalid output
+        proc = subprocess.run(args_list,shell=False, capture_output=True)
 
         if proc.returncode == 0:
             print(f'Make a big news! The newest report is now in {final_file}')

diff --git a/setup.py b/setup.py
@@ -5,7 +5,7 @@
 
 setuptools.setup(
     name="hkjournalist",
-    version="0.0.7",
+    version="0.0.8",
     author="Xinyi Li",
     author_email="[email protected]",
     description="Custom Auto Report Generator for Python Program",