Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added jlc bom assembly excel file #23

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

added jlc bom assembly excel file #23

wants to merge 11 commits into from

Conversation

zgonzalez24
Copy link
Contributor

Quality Assurance Checklist

To make reviews more efficient, please make sure the board meets the following standards and check everything off once the board meets the quality check. Once everything has been checked, the assigned reviewers will begin the review process. Edit this description to check off the list.

There are exceptions with all guidelines. As long as your decisions are justified, then you are good! Contact the reviewers or the leads about any exceptions.

Minimum Prerequisites

  • Pushed changes to branch.
  • The board passes ERC and DRC.
    • Note some ERC warnings are acceptable.
  • All traces are routed.
  • Units are in metric.

2D Spacing

  • The components are spaced out at an optimal distance.
    • All components can be easily hand-soldered.
    • IPC-SM-782A Standard requires a minimum distance of 1.0mm from edge to edge.
  • Components that are in parallel with each other are spaced out at an equal distance when possible.
  • The components are aligned with each other when possible.
  • Components are grouped based off of functionality.
    • E.g. all components for CAN should be grouped.
  • Bypass capacitors are less than 1cm away from their respective IC's power pins.

3D Spacing

  • Layout of components have been placed with mounting location and usage of the board in mind.
    • Are PCBs going to be stacked on above/below this board? Are tall components placed accordingly?
    • Are buttons and lights easily accessible and viewable?
    • When mounted into the car, are the heights of the components and connectors accounted for?
  • Location of connectors and wires going out of the board will prevent messy wiring.
    • Are all the wires that are going in the same direction placed on the same edge of the board?

Components

  • Custom footprints have been double checked with the datasheet.
  • Pin 1 of the footprint is labeled in some way.

Copper Layer

  • The trace widths and trace clearances are greater than JLCPCB's minimum requirements.
  • The trace lengths are as short as possible.
    • Can there be a more optimal route if you go to another layer?
  • Each trace's width is capable of handling the expected current flow.
    • Use PCB width calculator to calculate trace width.
  • *No sharp corners. No trace angles equal to or less than 90 degrees.
  • Traces are in parallel with each other when possible.
    • E.g. traces connected between an IC and MCU can be placed in parallel with each other.
  • There are no random trace appendages.
  • Vias placed in copper pads are fully encompassed in the copper pads.
  • Through-hole components do not have extraneous vias.

*Not really a problem for modern manufacturing techniques but good practice and important for high speed signal integrity.

Silkscreen Layer

  • Visible text sizes are greater than JLCPCB's minimum requirements.
  • All visible text is on the silkscreen layer.
  • All reference labels of each component are not overlapping a copper pad or another component.
  • All connector pins are labeled with a meaningful and helpful name.
  • All LEDs are labeled with a meaningful and helpful name.

Edge Cut Layer

  • The dimensions of the board and the mounting holes are nice values in metric i.e. no long decimals.
  • The physical outline of the board is on the edge cut layer.
  • Edge cuts are straight and parallel with opposite edge of the board.
  • Mounting holes are aligned.
  • Corners are curved and contoured to mounting holes.

IMPORTANT NOTICE

  • I am confident that this board will be safe to use in a safety critical environment.
  • [NO!!!!] I had fun :)

Other Comments

Write any comments about the board that would help the reviewers here.

@zgonzalez24
Copy link
Contributor Author

for the ferrite beads, there are the obsolete ferrite beads in the inventory, according to the excel sheet. I haven't checked it yet though. - Lucy

@Lakshay983
Copy link
Contributor

Add .lck files to your gitignore and then delete them from the repo (I like ur hostname lol)

@Lakshay983
Copy link
Contributor

Preferably y'all would add the part numbers as fields to the schematic. The part numbers would be baked into the schematic so in the future people can just change a part number on the schematic and then it all updates.

You can either press E on every component or (more preferably) go to Tools -> Edit Symbol Fields then you fill in all the part numbers there. You can also add a JLCPCB-specific field that is separate from the rest of the BOM.
This board is getting redone anyway so making y'all change that is a waste of your time. The excel sheet is fine, but in the future that's how you should do it.

@Lakshay983
Copy link
Contributor

Lakshay983 commented Apr 12, 2024

I'd recommend going through the process of uploading this stuff to JLCPCB and seeing what you're missing. You need a CPL file that outlines where components go. Also, let's only do manufacturing for the top side since that costs a lot extra to do both and the only things on the back are like 2 caps we can solder on ourselves.

JLCPCB Ordering website: https://cart.jlcpcb.com/quote

@loocyx
Copy link

loocyx commented Apr 13, 2024

Add .lck files to your gitignore and then delete them from the repo (I like ur hostname lol)

done!

Copy link
Contributor

@Lakshay983 Lakshay983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, when I upload the CPL it says it's not properly formatted. It lets me continue, but you can match the CPL and BOM such that it doesn't give me that error.

@Lakshay983
Copy link
Contributor

Lakshay983 commented Jun 2, 2024

R11 is an extended component on the current BOM, you can make it the same p/n as those resistors on R10

I thought nothing was assembled for the Exterior Lights section.
R1 - R4
C1 - C4, C32

R24 - R27 are extended components, it's only current limiting for the optoisolator, make them the same as the 120 ohm p/n that's basic

D14 is extended
Fix merge conflicts pls

R5 and R6 are 510 ohms on the schematic, the p/n links to a 100 ohm resistor

U5 - U11 are not on the BOM (the optoisolators). Use C32565

C14 is also not on the BOM. It's 100 nF, so the same as ur other 100 nF caps: C49678
D1 is not on BOM
L5 - L8 are not on the BOM (the CAN ferrite beads). C394483 seems like a good candidate. The ADM datasheet specifically requires something around 2 k ohm at 100 Mhz. Unfortunately the only ones i could find are extended.

Make D8, D14, and D1 all the same p/n. The basic one you have for D8 should work
Also, feel free to tune some of the resistor values for the current limiting resistors on the LEDs (if you have time and make sure they are all basic parts).

…hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants