Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diesel v1.4.4 Support #2

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

MarshallBelles
Copy link

Will test and see if there are any breaking changes to move to diesel version 1.4.4

@MarshallBelles MarshallBelles changed the title Adjusted diesel version to 1.4.4 in cargo.toml for testing. [WIP] Diesel v1.4.4 Support May 31, 2020
@MarshallBelles
Copy link
Author

After the above changes, reading from the DB is working. verified tests complete without issue when removing diesel insert code:

`
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

 Running target/debug/deps/hstore-8fae5df9d36a3e90

running 1 test
test metadata ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

Doc-tests diesel_pg_hstore

running 7 tests
test src/lib.rs - (line 15) ... ignored
test src/lib.rs - Hstore (line 113) ... ok
test src/lib.rs - (line 87) ... ok
test src/lib.rs - Hstore (line 131) ... ok
test src/lib.rs - Hstore::from_hashmap (line 153) ... ok
test src/lib.rs - (line 34) ... ok
test src/lib.rs - (line 52) ... ok

test result: ok. 6 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out
`

Need to find the cause to:
thread 'metadata' panicked at 'To insert data: DatabaseError(__Unknown, "null value in column \"store\" violates not-null constraint")', tests/hstore.rs:67:5

@MarshallBelles
Copy link
Author

thread 'metadata' panicked at 'To insert data: DatabaseError(__Unknown, "null value in column \"store\" violates not-null constraint")', tests/hstore.rs:67:5

Cause of this error was that QueryFragment was not fully implemented in a usable way.
This is now resolved.

@MarshallBelles
Copy link
Author

Ready for review.

@MarshallBelles MarshallBelles changed the title [WIP] Diesel v1.4.4 Support Diesel v1.4.4 Support May 31, 2020
@MarshallBelles
Copy link
Author

@lholden Please review and approve at your convenience.

@SchrodingerZhu
Copy link

This can be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants