Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tumbling/sliding inc window #3361

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Nov 7, 2024

No description provided.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 71.28028% with 83 lines in your changes missing coverage. Please review.

Project coverage is 71.07%. Comparing base (0f36acb) to head (b7a3d54).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/topo/node/window_inc_agg_op.go 67.86% 65 Missing and 7 partials ⚠️
internal/topo/planner/planner.go 85.00% 6 Missing and 3 partials ⚠️
pkg/timex/time.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3361      +/-   ##
==========================================
- Coverage   71.13%   71.07%   -0.05%     
==========================================
  Files         403      403              
  Lines       45810    46071     +261     
==========================================
+ Hits        32583    32744     +161     
- Misses      10666    10761      +95     
- Partials     2561     2566       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant