Ability to output ls/ps in json format #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncleDecart
reviewed
Aug 18, 2023
pkg/eve/applications.go
Outdated
| infoTime time.Time | ||
| MemoryUsed uint32 | ||
| MemoryAvail uint32 | ||
| CpuUsage int |
There was a problem hiding this comment.
Modified, thank you
There was a problem hiding this comment.
Now yetus is finally happy (with several nolint directives unfortunately)
| @@ -17,7 +19,7 @@ import ( | |||
| type NetInstState struct { | |||
| Name string | |||
| UUID string | |||
| NetworkType config.ZNetworkInstType | |||
| NetworkType string | |||
There was a problem hiding this comment.
Why would we want to switch to string?
There was a problem hiding this comment.
In my experiments I received value of variable here (some number), not a meaningful text (ZnetInstLocal from my sample). It is quite tricky to format it on-fly in marshaller.
giggsoff
force-pushed
the
json-ps
branch
3 times, most recently
from
d60e982
to
00976ee
Compare
Let's allow to use --format=json option to display lists
in machine-readable format.
```
$ ./eden volume ls --format=json
[
{
"Name": "pedantic_ganguly_0_m_0",
"UUID": "77a786a5-fc09-4b3d-946c-fbb4d77a72ce",
"Image": "lfedge/eden-eclient:b1c1de6",
"VolumeType": "CONTAINER",
"Size": "82 MB",
"MaxSize": "-",
"AdamState": "IN_CONFIG",
"EveState": "DELIVERED",
"LastError": "",
"Ref": "app: pedantic_ganguly",
"MountPoint": "/",
"OriginType": "VCOT_DOWNLOAD"
}
]
```
```
$ ./eden network ls --format=json
[
{
"Name": "flamboyant_goldstine",
"UUID": "c7b73fe8-f2eb-4304-b07a-9f8adcca8178",
"NetworkType": "ZnetInstLocal",
"CIDR": "10.11.12.0/24",
"Stats": "rx:{totalPackets:570 totalBytes:54758} tx:{totalPackets:2260 totalBytes:2607824}",
"AdamState": "IN_CONFIG",
"EveState": "ACTIVATED",
"Activated": true
}
]
```
```
$ ./eden pod ps --format=json
[
{
"Name": "pedantic_ganguly",
"UUID": "2877759b-5443-4952-b95e-004f244c87ad",
"Image": "lfedge/eden-eclient:b1c1de6",
"AdamState": "IN_CONFIG",
"EVEState": "RUNNING",
"InternalIP": [
"10.11.12.2"
],
"ExternalIP": "127.0.0.1",
"InternalPort": "22",
"ExternalPort": "8027",
"MemoryUsed": 181,
"MemoryAvail": 896,
"CPUUsage": 0,
"Macs": [
"ce:5b:cd:11:50:0f"
],
"Volumes": {
"77a786a5-fc09-4b3d-946c-fbb4d77a72ce": 100
}
}
]
```
Signed-off-by: Petr Fedchenkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's allow to use --format=json option to display lists in machine-readable format.