Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gic max version to boot on newer arm64 hosts #886

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

giggsoff
Copy link
Collaborator

@giggsoff giggsoff commented Aug 5, 2023

I can see problems while running on arm64 hosts with acceleration. Seems we should align gic version with the host one. According to docs, max is the best option here.

I can see problems while running on arm64 hosts with acceleration. Seems
 we should align gic version with the host one. According to docs
 (https://www.qemu.org/docs/master/system/arm/virt
 .html?highlight=gic%20version), max is the best option here.

Signed-off-by: Petr Fedchenkov <[email protected]>
Copy link
Member

@uncleDecart uncleDecart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd wait for BuildJet to merge or test in on buildjet runners, because they provide arm runners

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but do we want to wait until we've had some run(s) with the buildjet runners?

@giggsoff
Copy link
Collaborator Author

LGTM but do we want to wait until we've had some run(s) with the buildjet runners?

As I understand, we want to check arm buildjet runners and potentially stabilise other issues as well.

@uncleDecart
Copy link
Member

Exactly @giggsoff , right now we are running manually buildjet workflow ot see if there any problems
https://github.com/lf-edge/eve/actions/runs/6338260144

If not, we should explore buildjet arm runners (since they provide them) and if there is no problem with that, we can run this PR on buildjet arm runner and if it's successful, we can merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants