Add missing working-directory tag in run-eden-test action
#883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are using `test.yml` as reusable workflow in EVE we clone eden repository in EVE folder and it causes problems with working directories and building and executing binaries. So we are using `working-directory:` and `path:` tags of GitHub actions with hard-coded `./eden` value to prevent any problems that might occur with resuing this workflow in EVE. Signed-off-by: Pavel Abramov <[email protected]>
|
During running https://github.com/lf-edge/eden/actions/runs/5712658495/job/15476576181 there was an error with collect-info action, this PR should fix it |
milan-zededa
approved these changes
Jul 31, 2023
|
@eriknordmark can you please review and approve this? |
|
Problem is that as I understand is that globally setting it won't set it locally, but @yash-zededa can correct me if I'm wrong |
That's correct. I have tried to set this globally inside the actions and for me it was not working(I was getting error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are using
test.ymlas reusable workflow in EVE we clone eden repository in EVE folder and it causes problems with working directories and building and executing binaries.So we are using
working-directory:andpath:tags of GitHub actions with hard-coded./edenvalue to prevent any problems that might occur with resuing this workflow in EVE.