Traffic control for Eden-SDN #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this patch, Eden-SDN now allows to apply traffic control individually for every network port. This can be used to model poor network connectivity and observe how EVE is able to deal with such challenging conditions. Signed-off-by: Milan Lenco <[email protected]>
milan-zededa
force-pushed
the
traffic-control
branch
from
8e7dc21
to
47bdceb
Compare
uncleDecart
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
LGTM, but there's some weird failure with setup_eden. Worker runs out of space, most likely it's not because of this PR, but I suggest we finish all our shenanigans with workflows before merging this @milan-zededa
And thank you for this test Milan! 🎨
|
OK, let's finish the shenanigans first :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch, Eden-SDN now allows to apply traffic control individually for every network port. This can be used to model poor network connectivity and observe how EVE is able to deal with such challenging conditions.