Add docker openresty image and nginx image(with auto ssl) to list #1766
+21
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add docker openresty image with auto ssl to list， add docker nginx image with auto ssl to list
aarongable
requested changes
Nov 14, 2024
data/clients.json
Outdated
| { | ||
| "name": "docker-openresty", | ||
| "url": "https://github.com/xiaojun207/docker-openresty", | ||
| "category": "Docker", |
There was a problem hiding this comment.
I believe these belong in the "nginx" category more than they belong in the docker category.
There was a problem hiding this comment.
Yes, I agree with your assessment. I have changed it to "nginx". Thank you.
data/clients.json
Outdated
| "name": "docker-openresty", | ||
| "url": "https://github.com/xiaojun207/docker-openresty", | ||
| "category": "Docker", | ||
| "comments": "(这是一个可以自动申请（并自动更新）免费ssl证书的openresty镜像。This is a Openresty image with auto ssl，use acme.sh)", |
There was a problem hiding this comment.
We have a translations system for providing documentation pages in other languages. This description should remain in English so the translators can translate it to all of our supported languages.
data/clients.json
Outdated
Comment on lines
236
to
237
| "category": "Docker", | ||
| "comments": "(这是一个可以自动申请（并自动更新）免费ssl证书的nginx镜像。This is a Nginx image with auto ssl，use acme.sh)", |
change "docker-nginx" category to 'nginx' change "docker-openresty" category to 'nginx' fix comments to english
aarongable
reviewed
Nov 14, 2024
data/clients.json
Outdated
| "name": "docker-openresty", | ||
| "url": "https://github.com/xiaojun207/docker-openresty", | ||
| "category": "nginx", | ||
| "comments": "(This is a Openresty image with auto ssl，use acme.sh)", |
There was a problem hiding this comment.
Suggested change
| "comments": "(This is a Openresty image with auto ssl，use acme.sh)", | |
| "comments": "An Openresty image with auto ssl, using acme.sh", |
data/clients.json
Outdated
| "name": "docker-nginx", | ||
| "url": "https://github.com/xiaojun207/docker-nginx", | ||
| "category": "nginx", | ||
| "comments": "(This is a Nginx image with auto ssl，use acme.sh)", |
There was a problem hiding this comment.
Suggested change
| "comments": "(This is a Nginx image with auto ssl，use acme.sh)", | |
| "comments": "An Nginx image with auto ssl, using acme.sh", |
Optimize comment statements for docker-openresty and docker-nginx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add docker openresty image with auto ssl to list， add docker nginx image with auto ssl to list
Important
If this PR updates a file in
content/enwith alastmodfield, it must be updated.If this PR is a translation, please read https://github.com/letsencrypt/website/blob/master/TRANSLATION.md first.