Various CI/linting updates #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preston12321
requested review from
beautifulentropy
and removed request for
a team
aarongable
previously approved these changes
Oct 31, 2024
mcpherrinm
approved these changes
Nov 1, 2024
|
you could also bump the go version in go.mod. Some new go features or behaviour changes gate on that version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
24.041.23v1.60only-new-issues, because it can cause linter issues to get missed. Really, we should require all changes to be in full compliance with lints. If themainbranch is in full compliance, then the only issues that should show up on PRs will be the ones added in that change anyways.execinqueryexportlooprefgomndmalignedscopelinttypecheck