Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to libjpeg-turbo for Windows #142

Merged
merged 4 commits into from
May 11, 2021
Merged

Switch to libjpeg-turbo for Windows #142

merged 4 commits into from
May 11, 2021

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented May 10, 2021

Addresses #140

@kmilos
Copy link
Contributor Author

kmilos commented May 10, 2021

Hm, that last commit doesn't really make a difference: for python 3.6, 3.8 and 3.9 numpy (and blas) are grabbed from conda-forge for some reason, while for 3.7 it's happy with the default channel.

conda dependency resolving is just beyond me most of the time...

@letmaik
Copy link
Owner

letmaik commented May 10, 2021

Thanks for this. The channel thing is indeed odd. I think -c conda is the default anyway. Can we ping someone from conda to tell us why libjpeg-turbo affects numpy? Seems a bit weird. The PR otherwise is fine anyway. Just think it's a good opportunity to do a little investigation - if it takes too long we'll merge it anyway.

@kmilos
Copy link
Contributor Author

kmilos commented May 11, 2021

Can we ping someone from conda to tell us why libjpeg-turbo affects numpy?

No idea who to contact... And I don't think it's libjpeg-turbo per se affecting it, probably just the fact that it sees we're adding the conda-forge channel and decides to grab numpy from there for some version combinations.

@kmilos
Copy link
Contributor Author

kmilos commented May 11, 2021

Adding --strict-channel-priority seems to have done the trick.

@letmaik letmaik merged commit ae82264 into letmaik:master May 11, 2021
@kmilos kmilos deleted the patch-3 branch May 11, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants