fix(nvidia): use NVML + lspci to detect NVIDIA GPUs (without running nvidia-smi) #127
+213
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
changed the title
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
xiang90
reviewed
Oct 21, 2024
| if !smiInstalled { | ||
| return false, nil | ||
| } | ||
| log.Logger.Info("nvidia-smi installed") |
xiang90
reviewed
Oct 21, 2024
| if err != nil { | ||
| return false, err | ||
| } | ||
| log.Logger.Infow("detected nvidia gpu", "product", productName) |
There was a problem hiding this comment.
productName can also be a network card. do we check the type of the device?
There was a problem hiding this comment.
It's calling the device.GetName, so changed this logging to GPU device name.
Signed-off-by: Gyuho Lee <[email protected]>
xiang90
reviewed
Oct 21, 2024
|
|
||
| // now that nvidia-smi installed, | ||
| // check the NVIDIA GPU presence via PCI bus | ||
| pciDevices, err := ListPCIs(ctx) |
There was a problem hiding this comment.
it is only useful for printing?
There was a problem hiding this comment.
Renamed to ListNVIDIAPCIs. It's only listing the devices with NVIDIA name in it, thus checking whether the host has NVIDIA devices (we check len(results) > 0)
Signed-off-by: Gyuho Lee <[email protected]>
cardyok
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.