-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Https proxy env #259
Https proxy env #259
Conversation
Signed-off-by: Sami Tiilikainen <[email protected]>
A backwards compatible way to define HTTPS_PROXY as an empty value. Only this version knows how to replace it but older versions won't break from having the empty string. Signed-off-by: Sami Tiilikainen <[email protected]>
value: $LENS_BACKEND_URL | ||
- name: AUTO_UPDATE_URL | ||
value: $AUTO_UPDATE_URL | ||
command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we will add HTTPS_PROXY
also to the updater.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added and then renamed to BORED_HTTPS_PROXY so that it can be passed through but not used by the updater itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the PR description to explain this logic? For future reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Signed-off-by: Sami Tiilikainen <[email protected]>
When the env is just used for the updater to set in configs, not to use, call it BORED_HTTPS_PROXY Signed-off-by: Sami Tiilikainen <[email protected]>
There are two different envs for proxy:
Fixes #1208 (once the HTTPS_PROXY/BORED_HTTPS_PROXY also exists in lenscloud bored yaml files)