Code

Code improvements and fixes#72

Code

Merged

joshstevens19 merged 42 commits intodevelopmentlens-protocol/lens-v3:developmentfrom code-changeslens-protocol/lens-v3:code-changesCopy head branch name to clipboardJan 20, 2025

+1,625-1,379

Commits

Commits on Jan 7, 2025

• misc: TODO solved - isImmutable storage replaced by _contentURISnapshot length check

  donosonaumczuk

  committed
  20139fd

  Copy full SHA for 20139fd

Commits on Jan 9, 2025

• fix: Missing rule selector validation on primitives added

  donosonaumczuk

  committed
  8eab952

  Copy full SHA for 8eab952

• misc: compiler bump to 0.8.28 - pragma bump to ^0.8.26 - preparing for custom errors

  donosonaumczuk

  committed
  6f7274f

  Copy full SHA for 6f7274f

• misc: Custom Errors added on every revert case

  donosonaumczuk

  committed
  f3e80a0

  Copy full SHA for f3e80a0

Commits on Jan 10, 2025

• misc: add fuzzing, via_ir and zkSync compilation to foundry.toml

  vicnaum

  committed
  f4f8751

  Copy full SHA for f4f8751

• misc: commented out all lines that caused stack-too-deep

  vicnaum

  committed
  f435b95

  Copy full SHA for f435b95

• misc: Namespaces and Graph compile without IR

  vicnaum

  committed
  5873156

  Copy full SHA for 5873156

• misc: Rule Based Feed and Group made to compile without IR

  vicnaum

  committed
  706a0aa

  Copy full SHA for 706a0aa

• misc: RuleBasePrimitive made to compile without IR

  vicnaum

  committed
  0ba5dd1

  Copy full SHA for 0ba5dd1

• misc: Feed made to compile without IR

  vicnaum

  committed
  c5a740a

  Copy full SHA for c5a740a

• misc: MigrationFeed made to compile without IR

  vicnaum

  committed
  af083d7

  Copy full SHA for af083d7

• misc: LensFactory made to compile without IR

  vicnaum

  committed
  0aad9f2

  Copy full SHA for 0aad9f2

• misc: LensFactory tests made to compile without IR

  vicnaum

  committed
  cc4fe7e

  Copy full SHA for cc4fe7e

• Merge pull request #73 from lens-protocol/code-changes-compile-without-viair

  Show description for a157a84
  donosonaumczuk

  authored
  a157a84

  Copy full SHA for a157a84

Commits on Jan 11, 2025

• misc: Namespace code updated to give better revert reasons for non-existing usernames

  vicnaum

  committed
  cef1882

  Copy full SHA for cef1882

• test: coverage skipper added to deploy script

  vicnaum

  committed
  8198261

  Copy full SHA for 8198261

• test: coverage scripts added

  vicnaum

  committed
  e6ed308

  Copy full SHA for e6ed308

Commits on Jan 14, 2025

• misc: added checks for address(0) to GraphCore

  vicnaum

  committed
  0da8a99

  Copy full SHA for 0da8a99

• fix: MigrationGraph fixed

  vicnaum

  committed
  20e2200

  Copy full SHA for 20e2200

• fix: MigrationFeed extradata saving fix

  vicnaum

  committed
  283d303

  Copy full SHA for 283d303

• misc: Better error throwing during enable/disable rule selectors

  donosonaumczuk

  committed
  f4b42d5

  Copy full SHA for f4b42d5

• misc: SkipTokenGate refactored to a more generic SkipGate permission

  donosonaumczuk

  committed
  738c509

  Copy full SHA for 738c509

• fix: Added missing _processEntityRulesChanges override on Feed and Graph

  donosonaumczuk

  committed
  dfd8e4b

  Copy full SHA for dfd8e4b

• misc: getUsernameTokenId modifier from view to pure

  donosonaumczuk

  committed
  a936313

  Copy full SHA for a936313

Commits on Jan 15, 2025

• misc: add TippingPostAction to deployment script

  vicnaum

  committed
  df046e9

  Copy full SHA for df046e9

Commits on Jan 16, 2025

• fix: Post Rules events emitters added

  vicnaum

  committed
  fdbd1c7

  Copy full SHA for fdbd1c7

• fix: Follow Rules events emitters added

  vicnaum

  committed
  1a5ce2a

  Copy full SHA for 1a5ce2a

• fix: editPost fixed (core call missing)

  vicnaum

  committed
  dd7919c

  Copy full SHA for dd7919c

• misc: MigrationFeed changed to have forceChecks always

  vicnaum

  committed
  b862efd

  Copy full SHA for b862efd

• fix: Rule processing main for-loop logic fixed - Call with empty params when processing params not present

  donosonaumczuk

  committed
  404b461

  Copy full SHA for 404b461

• misc: bool return from call renamed to callSucceeded for better code semantics

  donosonaumczuk

  committed
  3984082

  Copy full SHA for 3984082

• misc: IAccessControl incomplete natspec comment completed

  donosonaumczuk

  committed
  036baf8

  Copy full SHA for 036baf8

• fix: Access Control verification function now calls with address(this) and 1 instad of address(0) and 0, to avoid reverting with invalid param

  donosonaumczuk

  committed
  a7dce24

  Copy full SHA for a7dce24

• misc: Diff error constants and validations moved up on RoleBasedAccessControl

  donosonaumczuk

  committed
  3ce2ff1

  Copy full SHA for 3ce2ff1

Commits on Jan 17, 2025

• misc: proxy__ prefix added to BeaconProxy functions

  donosonaumczuk

  committed
  b1652f7

  Copy full SHA for b1652f7

• fix: make all the rule-related hooks abstract and required to override

  vicnaum

  committed
  95176ad

  Copy full SHA for 95176ad

• feat: handledcall and handledsafecall added to CallLib

  donosonaumczuk

  committed
  7395e05

  Copy full SHA for 7395e05

• fix: properly retrieve selector from ProxyAdmin call's calldata

  donosonaumczuk

  committed
  a0bb896

  Copy full SHA for a0bb896

• fix: Use handled flavour for safecall and call when needed

  donosonaumczuk

  committed
  96c48f6

  Copy full SHA for 96c48f6

Commits on Jan 18, 2025

• misc: processRemovePost renamed to processDeletePost

  vicnaum

  committed
  f458e57

  Copy full SHA for f458e57

• misc: _handleCall changed to pure

  vicnaum

  committed
  f0128a6

  Copy full SHA for f0128a6

• misc: Renames Self() error to ActionOnSelf() to prevent clashing with Rust reserved keyword

  vicnaum

  committed
  d93a72f

  Copy full SHA for d93a72f