Lis histogram element #386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stacked data model will also live here.
|
No rush @adf-ncgr and @alancleary as you guys have time to review this. I'm going to move on to other views in the meantime. DSCensor replace inc... |
alancleary
requested changes
May 7, 2024
There was a problem hiding this comment.
Overall I think this is a solid start. There's a handful of minor changes that need to be made; see my code comments for details.
Two things I want to discuss here are:
- The size of the component is completely independent of the component's container so I don't see the need for the ResizeObserver. I think it would be cool if the width/height of the histogram were drawn to be the width/height of the container if a width/weight isn't explicitly specified. For example, you would give an explicit width but leave the height empty so the height would be the size of the container. Alternatively, it might make sense to let the "name" axis to be as large as it needs to be to fit the given data.
- I think having
xlabelandylabelproperties is confusing because the orientation switches what axis the labels are in. Would it make sense instead to name the label by the data on their axis? For example,nameLabelandcountLabel.
…ed axis labels to nameLabel and countLabel. #386
|
Closing this. Will resubmit with changes so its easier to track. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a component to use for histograms.
See:
http://dev.lis.ncgr.org:50050/dev/core/lis-histogram-element.html
Docs:
http://dev.lis.ncgr.org:50050/docs/classes/core_components.LisHistogramElement.html