Refactor messengers #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor out a helper function to initialize an interactive session. This allows to do a late intitialization of an interactive session. Before that change, using the command to use an interactive session just segfaulted with a null ptr deref. * There is an upstream bug with bools in G4GenericMessenger, only numeric values work, other values like `true` will be silently ignored. * Some commands in `RMGPhysics` have been restricted to the PreInit state. see `G4DeexPrecoParameters::IsLocked()` which just _silently_ discards any changes to the `G4DeexPrecoParameters` if the state is not PreInit. * Some guidance and parameter name changes.
ManuelHu
force-pushed
the
messenger-refactor
branch
from
69c4409
to
61b7617
Compare
|
see also upstream bug report https://bugzilla-geant4.kek.jp/show_bug.cgi?id=2606 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
G4GenericMessenger::DeclareMethod(), only numeric values work, other values liketruewill be silently ignored.I have added a temporary fix to the affected physics commands, and switched
/RMG/Manager/InteractivetoDeclareProperty(which is not affected by the bug)RMGPhysicshave been restricted to the PreInit state.see
G4DeexPrecoParameters::IsLocked()which just silently discards any changes to theG4DeexPrecoParametersif the state is not PreInit.