-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement musun input generator #26
Implement musun input generator #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I left a couple of comments.
What is the status here? Only need to better handle the header as we discussed? |
include/ProjectInfo.hh
Outdated
@@ -0,0 +1,9 @@ | |||
// other useful GEANT4 exported variables: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be removed, it has been replaced by the (git-excluded) RMGConfig.hh
|
||
#include "G4ThreeVector.hh" | ||
|
||
#include "ProjectInfo.hh" |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually that import is completely unnecessary here (i.e. none of the RMG_HAS_*
constants are actually used) , isn't it?
6758b15
to
793337c
Compare
Now there are some parts of recent |
|
||
#include "G4ThreeVector.hh" | ||
|
||
#include "ProjectInfo.hh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually that import is completely unnecessary here (i.e. none of the RMG_HAS_*
constants are actually used) , isn't it?
…uberger/remage into implement_MUSUN_input_generator
So, there is a problem with the multithreaded implementation. The G4CsvAnalysisReader instance is currently initialized in the |
At this point I am thinking of working with a singelton and mutex similar to this Geant4 example. |
…uberger/remage into implement_MUSUN_input_generator
…uberger/remage into implement_MUSUN_input_generator
Multithreaded seems to work now. |
…uberger/remage into implement_MUSUN_input_generator
In the example I now get this seg violation:
I guess I messed up somewhere. |
…uberger/remage into implement_MUSUN_input_generator
Seems to not throw the seg violation anymore. It was probably related to an automatic delete of the Anyway, I think the pull request is now feature-complete. What do you guys think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some macro commands will not work on current main
Co-authored-by: Manuel Huber <[email protected]>
Co-authored-by: Manuel Huber <[email protected]>
Co-authored-by: Manuel Huber <[email protected]>
Co-authored-by: Manuel Huber <[email protected]>
Co-authored-by: Manuel Huber <[email protected]>
…uberger/remage into implement_MUSUN_input_generator
Overview: