Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow /RMG/Processes/Stepping/DaughterNucleusMaxLifetime in idle state #147

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

ManuelHu
Copy link
Collaborator

@ManuelHu ManuelHu commented Nov 6, 2024

  • it is safe to use in idle state, too
  • it is not registered yet in pre-init state in MT mode
  • remove it from pre-init state to make macros behave consistently between MT/serial modes

this breaks all macros that used this option until now.. :-( but fixing is simple (just moving the command after /run/initialize)


other options to fix these incosistencies:

  • move the command to the physics messenger and read from the physics instance in the stepping action (might be slower?)
  • initialize all (user) actions also on master, including Stepping-, Stacking-, TrackingActions... Currently we only have Run- and GeneratorActions on the master

… state

* it is safe to use in idle state, too
* it is not registered yet in pre-init state in MT mode
* remove it from pre-init state to make macros behave consistently between MT/serial modes
@ManuelHu ManuelHu merged commit 7f9ee62 into main Nov 7, 2024
6 checks passed
@ManuelHu ManuelHu deleted the mt-stepping-messenger branch November 7, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant