Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on Requires #68

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Drop dependency on Requires #68

merged 1 commit into from
Sep 19, 2024

Conversation

fhagemann
Copy link
Contributor

If LegendDataManagement requires at least julia 1.9, the dependency on Requires is needed and it can be dropped.

(Needed only if we plan to officially register LegendDataManagement - then we might need Requires because LegendHDF5IO is not registered, see SolidStateDetectors)

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.00%. Comparing base (71b5e3b) to head (2940121).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   33.02%   33.00%   -0.03%     
==========================================
  Files          27       27              
  Lines        1620     1618       -2     
==========================================
- Hits          535      534       -1     
+ Misses       1085     1084       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fhagemann fhagemann added the dependencies Pull requests that update a dependency file label Sep 18, 2024
@fhagemann fhagemann requested review from apmypb and oschulz and removed request for apmypb September 18, 2024 13:47
@fhagemann fhagemann merged commit 469a00e into legend-exp:main Sep 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant