Initialize _pool array in tinyxml2.h #980
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added {} to the declaration of the _pool array in the tinyxml2.h file. This ensures that all elements of the _pool array are initialized to their default values. This change improves the safety and predictability of the code by preventing uninitialized values.
|
I'm not sure when that was added to C++ - old compilers certainly don't like it. (I checked godbolt.) It's minor, so it's probably not worth breaking compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added {} to the declaration of the _pool array in the tinyxml2.h file. This ensures that all elements of the _pool array are initialized to their default values. This change improves the safety and predictability of the code by preventing uninitialized values.