Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better progress ux #542

Merged
merged 1 commit into from
Oct 25, 2024
Merged

feat: better progress ux #542

merged 1 commit into from
Oct 25, 2024

Conversation

mhuisi
Copy link
Collaborator

@mhuisi mhuisi commented Oct 25, 2024

This PR improves two things about the way we report progress:

  • Instead of attempting to badly approximate an accurate progress bar that gets stuck whenever the output of a command doesn't change, we now use VS Code's "infinite" progress bars everywhere that clearly show that an operation is actively running in the background.
  • Every progress bar is prefixed with a context to make it clear which operation caused the operation. For example, when creating a new mathlib project, all external commands executed while creating the project are prefixed with "[Create Mathlib Project]".

Closes #457. IMO, our dialog UX still isn't perfect, but there doesn't seem to be a good way to improve these things short of implementing our own webviews for every command.

@mhuisi mhuisi merged commit 7c86548 into master Oct 25, 2024
1 of 2 checks passed
@mhuisi mhuisi deleted the mhuisi/create-project-ux branch October 25, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: more visible feedback when creating a new project
1 participant