Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vscode-languageclient version #162

Merged
merged 6 commits into from
Apr 13, 2022
Merged

Update vscode-languageclient version #162

merged 6 commits into from
Apr 13, 2022

Conversation

marianaalanis93
Copy link
Collaborator

@marianaalanis93 marianaalanis93 commented Apr 5, 2022

This PR contains (related with #114).

  • Update vscode-languageclient version from 7.0.0. to 8.0.0-next.14 (language client newest version).

PR #159 needs to merge this current PR (#162) first to get the complete solution working.

@Vtec234
Copy link
Member

Vtec234 commented Apr 6, 2022

It looks like the Windows build is failing, any ideas?

Copy link
Member

@gebner gebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting for the windows CI fix first.

@marianaalanis93
Copy link
Collaborator Author

marianaalanis93 commented Apr 12, 2022

@lovettchris @gebner @Vtec234 finally found the issue with the GitHub workflow, please check the #163 PR :) thanks! #163

@marianaalanis93
Copy link
Collaborator Author

Just waiting for the windows CI fix first.

Fixed and waiting for review :)

@Vtec234 Vtec234 merged commit 7d3aebd into master Apr 13, 2022
@clovett clovett mentioned this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants