Try adding macos binary upload from actions workflow

lczech · Jan 24, 2024 · 5ba9f47 · 5ba9f47
1 parent c1b8188
commit 5ba9f47
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -127,8 +127,15 @@ jobs:
           #   compiler: apple
           - os: macos-11
             compiler: apple
+            static: "true"
           - os: macos-12
             compiler: apple
+            static: "true"
+
+          # Include extra static builds that we want for distributable binaries
+          - os: ubuntu-22.04
+            compiler: gcc-13
+            static: "true"
 
     # ==========================================================================
     #     Steps
@@ -190,9 +197,10 @@ jobs:
             sudo xcode-select --switch /Library/Developer/CommandLineTools
           fi
 
-          # For static builds, set the according CMake option
+          # For static builds, set the according CMake option. We never build static on MacOS,
+          # as that is not easy: https://stackoverflow.com/q/3801011
           export GRENEDALF_BUILD_STATIC=""
-          if [[ "${{ matrix.os }}" == "ubuntu-22.04" ]] && [[ "${{ matrix.compiler }}" == "gcc-13" ]]; then
+          if [[ "${{ matrix.static }}" == "true" ]] && [[ "${{ matrix.os }}" != *"macos"* ]]; then
             export GRENEDALF_BUILD_STATIC="-DGRENEDALF_BUILD_STATIC=ON"
           fi
 
@@ -225,7 +233,7 @@ jobs:
       # -------------------------------------------------------
 
       - name: Upload Binaries
-        if: matrix.os == 'ubuntu-22.04' && matrix.compiler == 'gcc-13'
+        if: matrix.static == 'true'
         uses: actions/upload-artifact@v3
         with:
           name: binary-${{ matrix.os }}