Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-5187: add clearer warning to mandatee table on losing changes #509

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

elpoelma
Copy link
Collaborator

@elpoelma elpoelma commented Nov 18, 2024

Overview

This PR includes two adjustments to the synchronisation warning shown in mandatee table nodes:

  • The message is now clearer/more correct
  • The message is now shown in a yellow AuAlert component
connected issues and PRs:

GN-5187

Setup

None

How to test/reproduce

  • Start the dummy app
  • Open the 'Besluit sample' page
  • Insert a mandatee table
  • The sync warning should be clearer in terms of message as well as visibility

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check if dummy app is correctly updated
  • Check cancel/go-back flows
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma added the enhancement New feature or request label Nov 18, 2024
@elpoelma elpoelma merged commit 44fedc4 into master Nov 18, 2024
2 of 3 checks passed
@elpoelma elpoelma deleted the GN-5187-mandatee-table-warning branch November 18, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants