Move virtuoso.ini files to seperate config folder
#209
Conversation
elpoelma
changed the title
virtuoso.ini files to seperate config folder
| ;; Uncomment next two lines if there is 8 GB system memory free | ||
| ;NumberOfBuffers = 680000 | ||
| ;MaxDirtyBuffers = 500000 | ||
| NumberOfBuffers = 680000 |
There was a problem hiding this comment.
Why do we have 4G but we have uncommented the lines for 8gb of free memory?
| [TempDatabase] | ||
| DatabaseFile = /usr/local/virtuoso-opensource/var/lib/virtuoso/db/virtuoso-temp.db | ||
| TransactionFile = /usr/local/virtuoso-opensource/var/lib/virtuoso/db/virtuoso-temp.trx | ||
| MaxCheckpointRemap = 000 |
There was a problem hiding this comment.
It's not clear to me why this is 0 or what that means in practice. In QA it's 2000.
There was a problem hiding this comment.
I'm not sure either. I left the production config (taken from the prod server) unchanged, as I don't really understand all the parameters.
| MaxQueryMem = 4G ; memory allocated to query processor ;;Niels said to 4g | ||
| VectorSize = 1000 ; initial parallel query vector (array of query operations) size | ||
| MaxVectorSize = 1000000 ; query vector size threshold. | ||
| AdjustVectorSize = 0 |
There was a problem hiding this comment.
This being 0 here and 1 on production could cause differences in behaviour between them, I'm not familiar enough with these settings to know whether that's an issue.
There was a problem hiding this comment.
Same comment as above. I'm also not familiar enough, so I left these settings unchanged.
| @@ -62,6 +62,7 @@ services: | |||
| DEFAULT_GRAPH: "http://mu.semte.ch/application" | |||
| volumes: | |||
| - ./data/db:/data | |||
| - ./config/virtuoso/virtuoso.ini:/data/virtuoso.ini # Note: on production override this setting | |||
There was a problem hiding this comment.
As far as my thinking goes, the docker-compose.yml file should be the production version. The .dev.yml should include the version for development (mapping the same internal path means that the latest mapping wins).
There was a problem hiding this comment.
That's also fair! I mainly based this approach/config on the one of LMB and Loket, to maintain a bit of consistency.
Overview
This PR makes some adjustments to the
virtuoso.inifiles and where they are stored.This PR stores the
.inifiles in/config/virtuoso. This approach is similar to the ones taken by https://github.com/lblod/app-lokaal-mandatenbeheer and https://github.com/lblod/app-digitaal-loket.This PR also introduces seperate
virtuoso.inifiles for:Finally, this PR also adjusts some parameters of the
.inifiles, mostly in terms of maximum memory usage.Tracking the
.inifiles for DEV/QA and production allows us to easily tweak the parameters.