Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue2465 remove and3 #3490

Merged
merged 5 commits into from
Aug 31, 2023
Merged

Issue2465 remove and3 #3490

merged 5 commits into from
Aug 31, 2023

Conversation

hcasperfu
Copy link
Contributor

This closes #2465.

@hcasperfu hcasperfu requested a review from mwetter August 30, 2023 17:31
Copy link
Member

@mwetter mwetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hcasperfu : This looks good, but please also add an entry in the conversion script Resources/Scripts/Conversion/ConvertBuildings_from_9_to_10.0.0.mos.
You can then test this entry by making a test model that uses And3 and Buildings 9.0.0, and open it with Buildings master (10.0.0). This should update the And3 in the test model.

@hcasperfu
Copy link
Contributor Author

Conversion scripts added in 977e186.

@mwetter mwetter added this to the Release 10.0 milestone Aug 30, 2023
@mwetter mwetter enabled auto-merge (squash) August 30, 2023 23:48
@mwetter mwetter merged commit 1ad1579 into master Aug 31, 2023
2 checks passed
@mwetter mwetter deleted the issue2465_RemoveAnd3 branch August 31, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to CDL
2 participants