Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue3481 spawn zone capacitance multiplier #3482

Merged
merged 14 commits into from
Aug 30, 2023
Merged

Issue3481 spawn zone capacitance multiplier #3482

merged 14 commits into from
Aug 30, 2023

Conversation

hcasperfu
Copy link
Contributor

This closes #3481.
This PR is currently awaiting #3209 to be merged to master. Once it is, the results will be updated.

@mwetter
Copy link
Member

mwetter commented Aug 25, 2023

@hcasperfu : Thanks, that looks good, but I would move Buildings/ThermalZones/EnergyPlus_9_6_0/Examples/SingleFamilyHouse/ZoneCapacitanceMultiplier.mo to the Validation package as it is a validation rather than an example in which we would show users how to use certain models.

@hcasperfu
Copy link
Contributor Author

I moved the model to Validation.ThermalZone.

@mwetter mwetter marked this pull request as ready for review August 30, 2023 15:49
@mwetter mwetter merged commit c34386a into master Aug 30, 2023
2 checks passed
@mwetter mwetter deleted the issue3481_spawnZoneCapacitanceMultiplier branch August 30, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate zone capacitance multiplier for Spawn
2 participants
@hcasperfu @mwetter