Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue3470 restrict to two pumps #3471

Merged
merged 3 commits into from
Aug 12, 2023
Merged

Issue3470 restrict to two pumps #3471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
633c08d
set totPum.nin = numPum
hcasperfu Aug 9, 2023
5b09336
updated documentation and release notes
hcasperfu Aug 9, 2023
8d42c7c
Corrected description
mwetter Aug 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions Buildings/Experimental/DHC/Plants/Cooling/Controls/ChilledWaterPumpSpeed.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
within Buildings.Experimental.DHC.Plants.Cooling.Controls;
model ChilledWaterPumpSpeed
"Controller for up to two headered variable speed chilled water pumps"
"Controller for two headered variable speed chilled water pumps"
extends Modelica.Blocks.Icons.Block;
parameter Modelica.Units.SI.PressureDifference dpSetPoi(displayUnit="Pa")
"Pressure difference setpoint";
Expand Down Expand Up @@ -80,7 +80,7 @@ model ChilledWaterPumpSpeed
annotation (Placement(transformation(extent={{-80,-50},{-60,-30}})));
Modelica.Blocks.Math.RealToBoolean twoPum(threshold=1.5) "Two pumps are on"
annotation (Placement(transformation(extent={{10,-60},{-10,-40}})));
Modelica.Blocks.Math.Sum totPum(nin=2) "Total number of pumps on"
Modelica.Blocks.Math.Sum totPum(final nin=numPum) "Total number of pumps on"
annotation (Placement(transformation(extent={{42,-60},{22,-40}})));
Modelica.Blocks.Interfaces.BooleanInput on
"On signal of the plant"
Expand Down Expand Up @@ -161,6 +161,20 @@ equation
revisions="<html>
<ul>
<li>
August 9, 2023, by Hongxiang Fu:<br/>
Restricted this block to a two-pump configuration as intended.
<ul>
<li>
Set <code>final totPum.nin = numPum</code>.
</li>
<li>
Corrected the \"up to two pumps\" language in documentation.
</li>
</ul>
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/3470\">#3470</a>.
</li>
<li>
December 30, 2022, by Kathryn Hinkelman:<br/>
Added an <code>on</code> input for a plant-level override to turn pumps off.
</li>
Expand Down Expand Up @@ -193,7 +207,7 @@ reference point from the demand side. The output <code>y</code> is a vector
of pump speeds.
</p>
<p>
The model currently only supports the control of up to two variable speed pumps.
The model currently only supports the control of two variable speed pumps.
</p>
</html>"));
end ChilledWaterPumpSpeed;
12 changes: 12 additions & 0 deletions Buildings/package.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,18 @@ have been <b style=\"color:blue\">improved</b> in a
<b style=\"color:blue\">backward compatible</b> way:
</p>
<table class=\"releaseTable\" summary=\"summary\" border=\"1\" cellspacing=\"0\" cellpadding=\"2\" style=\"border-collapse:collapse;\">
<tr><td colspan=\"2\"><b>Buildings.Experimental.DHC.Plants.Cooling</b>
</td>
</tr>
<tr><td valign=\"top\">Buildings.Experimental.DHC.Plants.Cooling.Controls.ChilledWaterPumpSpeed
</td>
<td valign=\"top\">Set <code>final totPum.nin = numPum</code> so that this block is restricted
to a two-pump configuration as intended.
Also corrected the \"up to two pumps\" language in documentation.<br/>
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/3470\">issue 3470</a>.
</td>
</tr>
<tr><td colspan=\"2\"><b>Buildings.ThermalZones.Detailed.Validation.BESTEST</b>
</td>
</tr>
Expand Down