First release of the Templates package (VAV system) #2925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssue1374_templates
This is a technical debt. This allows redeclaring secOutRel.secOut w/o warning. But this prevents from redeclaring secOutRel. The alternative would be to build a generic container class with all possible (replaceable) instances of secOut and secRel covering all supported configurations (for secOutRel). Each instance may thus have dedicated choices annotations.
…ssue1374_templates
This configuration is not supported by G36. And the model now fails to simulate with OCT and Dymola.
…ssue1374_templates
…ssue1374_templates
…ssue1374_templates
…ssue1374_templates
- Add simulate and plot command. - Improve doc for model parameterization. - Propagate allowFlowReversal and energyDynamics. - Annotate record instance with placement.
- Use a signed variable for cap and assign -/+ abs(cap) to Q_flow. - Add simulation parameters to components. - Add icons to template classes. - Fix URI. - Add validation models.
…ssue1374_templates
|
Ready to merge when all tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to initiate the review process: please review as it was intended to be merged to MBL master.
The classes of interest for the review are within
Buildings.Templates.(If useful I have started putting my notes about template development at https://antoinegautier.github.io/template-dev-docs/.)
TODO
issue1913_g36_final