Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix skipping expired additionalDates #1838

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Fix skipping expired additionalDates #1838

merged 1 commit into from
Dec 1, 2023

Conversation

eltoder
Copy link
Contributor

@eltoder eltoder commented Nov 21, 2023

  • Do not assume additionalDates are sorted.
  • Fix appending additionalDates to dates (2*firstAdditionalDate_ were skipped leading to an abort later).
  • Simplify the code.

@eltoder
Fix skipping expired additionalDates
3a00f85 
* Do not assume additionalDates are sorted.
* Fix appending additionalDates to dates (2*firstAdditionalDate_ were
  skipped leading to an abort later).
* Simplify the code.
@coveralls
Copy link

Coverage Status

coverage: 72.029% (-0.001%) from 72.03%
when pulling 3a00f85 on eltoder:feature/global-bootstrap-fix-additional-dates
into 7ae8d53 on lballabio:master.

@lballabio lballabio added this to the Release 1.33 milestone Dec 1, 2023
@lballabio lballabio merged commit e0e8a08 into lballabio:master Dec 1, 2023
49 checks passed
@eltoder eltoder deleted the feature/global-bootstrap-fix-additional-dates branch December 1, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.33
Development

Successfully merging this pull request may close these issues.
3 participants
@eltoder @coveralls @lballabio