fix: Honor explicitly set default value #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When evaluating flags, the test harness has relied on the [`inferDefaultFromFlag`][1] to replace an explicitly null value with an inferred default value of the correct type. This kind of magic only leads to confusion (hence this PR), and isn't necessary. SDKs should be able to handle a null default as well as any other type. [1]: https://github.com/launchdarkly/sdk-test-harness/blob/cb433a1206c5190796c021605c401b5cbaf5799c/sdktests/helpers.go#L137
tanderson-ld
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When evaluating flags, the test harness has relied on the
inferDefaultFromFlagto replace an explicitly null value with aninferred default value of the correct type.
This kind of magic only leads to confusion (hence this PR), and isn't
necessary. SDKs should be able to handle a null default as well as any
other type.