fix: don't send 'null' when no prereqs present #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
approved these changes
Oct 28, 2024
cwaldren-ld
pushed a commit
that referenced
this pull request
Oct 29, 2024
🤖 I have created a release *beep* *boop* --- ## [2.24.2](v2.24.1...v2.24.2) (2024-10-29) ### Bug Fixes * don't send 'null' when no prereqs present ([#251](#251)) ([6480865](6480865)) * summary events should allow null default value in counter ([#253](#253)) ([9b4d98f](9b4d98f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we send
"prerequisites": nullin the tests that don't deal with prerequisites. While this should be acceptable to SDKs without causing issues, it's not what LaunchDarkly would send (it should omit the array.)This adds
omitEmptyto omit the key altogether if it's empty.This did catch an implementation bug I had in the .NET client, so it's clearly valuable to test setting properties to null. But I don't think we consistently do that on purpose in the existing tests (could be wrong, didn't audit).