fix: Babel TypeError due to event-target-shim #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusinto
requested review from
kinyoklion and
louis-launchdarkly
as code owners
|
This pull request has been linked to Shortcut Story #232716: Fix event-target-shim TypeError. |
yusinto
commented
Feb 7, 2024
Comment on lines
+26
to
+30
| "expo": "~50.0.6", | ||
| "expo-splash-screen": "~0.26.4", | ||
| "expo-status-bar": "~1.11.1", | ||
| "react": "18.2.0", | ||
| "react-native": "0.72.6", | ||
| "react-native": "0.73.4", |
There was a problem hiding this comment.
Main changes are expo 50 and rn 0.73.
| @@ -2,7 +2,7 @@ | |||
| * Ripped from: | |||
| * https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/Events/CustomEvent.js#L21 | |||
| */ | |||
| import { Event } from 'event-target-shim'; | |||
| import { Event } from 'event-target-shim/es5'; | |||
There was a problem hiding this comment.
This fixes the babel TypeError.
kinyoklion
approved these changes
Feb 7, 2024
Merged
yusinto
pushed a commit
that referenced
this pull request
Feb 7, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>js-client-sdk-common: 0.2.1</summary> ## [0.2.1](js-client-sdk-common-v0.2.0...js-client-sdk-common-v0.2.1) (2024-02-07) ### Bug Fixes * Minor fixes from docs pr review. ([#363](#363)) ([4768bf7](4768bf7)) </details> <details><summary>react-native-client-sdk: 0.2.1</summary> ## [0.2.1](react-native-client-sdk-v0.2.0...react-native-client-sdk-v0.2.1) (2024-02-07) ### Bug Fixes * Babel TypeError due to event-target-shim ([#365](#365)) ([c1c0086](c1c0086)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk-common bumped from 0.2.0 to 0.2.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a babel issue related to the event-target-shim package. For unknown reasons, in Expo 50, the metro bundler is unable to transpile event-target-shim correctly resulting in the error below.
Thankfully the event-target-shim package offers a transpiled es5 version which seems to work. We'll use that instead.