Skip to content

Commit

Permalink
fix: Export correct options for compat. (#678)
Browse files Browse the repository at this point in the history
  • Loading branch information
kinyoklion authored Nov 13, 2024
1 parent 6c4bb82 commit 8d8250c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
3 changes: 1 addition & 2 deletions packages/sdk/browser/src/common.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import { BasicLogger, BasicLoggerOptions, LDLogger } from '@launchdarkly/js-client-sdk-common';

import { BrowserIdentifyOptions as LDIdentifyOptions } from './BrowserIdentifyOptions';
import { BrowserOptions as LDOptions } from './options';

// The exported LDIdentifyOptions and LDOptions are the browser specific implementations.
// These shadow the common implementations.
export type { LDIdentifyOptions, LDOptions };
export type { LDIdentifyOptions };

export type {
AutoEnvAttributes,
Expand Down
5 changes: 3 additions & 2 deletions packages/sdk/browser/src/compat/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,14 @@
* Some code changes may still be required, for example {@link LDOptions} removes
* support for some previously available options.
*/
import { LDContext, LDOptions } from '@launchdarkly/js-client-sdk-common';
import { LDContext } from '@launchdarkly/js-client-sdk-common';

import { LDClient } from './LDClientCompat';
import LDClientCompatImpl from './LDClientCompatImpl';
import { LDOptions } from './LDCompatOptions';

export * from '../common';
export type { LDClient };
export type { LDClient, LDOptions };

/**
* Creates an instance of the LaunchDarkly client. This version of initialization is for
Expand Down
4 changes: 2 additions & 2 deletions packages/sdk/browser/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
import { AutoEnvAttributes } from '@launchdarkly/js-client-sdk-common';

import { BrowserClient, LDClient } from './BrowserClient';
import { LDOptions } from './common';
import { BrowserOptions as LDOptions } from './options';

export * from './common';
export type { LDClient };
export type { LDClient, LDOptions };

/**
* Creates an instance of the LaunchDarkly client.
Expand Down

0 comments on commit 8d8250c

Please sign in to comment.