Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds support for client side prerequisite events. #39

Merged
merged 5 commits into from
Oct 24, 2024
Merged

feat: Adds support for client side prerequisite events. #39

merged 5 commits into from
Oct 24, 2024

Conversation

tanderson-ld
Copy link
Contributor

@tanderson-ld tanderson-ld commented Oct 23, 2024 •
edited
Loading

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

SDK-687

@tanderson-ld tanderson-ld changed the title Adds support for client side prerequisite events. feat: Adds support for client side prerequisite events. Oct 23, 2024
louis-launchdarkly
louis-launchdarkly reviewed Oct 23, 2024
View reviewed changes
Copy link

@louis-launchdarkly louis-launchdarkly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far this looks good, let me know when the TODO are done, I can approve.

@tanderson-ld tanderson-ld marked this pull request as ready for review October 23, 2024 20:30
@tanderson-ld tanderson-ld requested a review from a team as a code owner October 23, 2024 20:30
@tanderson-ld
Copy link
Contributor Author

TODO: performance bench testing to validate prerequisite list allocation performance.

Performance isn't significantly impacted

Prereq branch
Benchmark Mode Cnt Score Error Units
LDClientEvaluationBenchmarks.allFlagState avgt 100 407.517 ± 5.443 ns/op
LDClientEvaluationBenchmarks.allFlagState:·gc.alloc.rate avgt 100 2489.288 ± 31.002 MB/sec
LDClientEvaluationBenchmarks.allFlagState:·gc.alloc.rate.norm avgt 100 1594.846 ± 0.004 B/op
LDClientEvaluationBenchmarks.allFlagState:·gc.churn.G1_Eden_Space avgt 100 2371.667 ± 33.377 MB/sec
LDClientEvaluationBenchmarks.allFlagState:·gc.churn.G1_Eden_Space.norm avgt 100 1519.796 ± 14.185 B/op
LDClientEvaluationBenchmarks.allFlagState:·gc.churn.G1_Survivor_Space avgt 100 0.013 ± 0.001 MB/sec
LDClientEvaluationBenchmarks.allFlagState:·gc.churn.G1_Survivor_Space.norm avgt 100 0.008 ± 0.001 B/op
LDClientEvaluationBenchmarks.allFlagState:·gc.count avgt 100 1911.000 counts
LDClientEvaluationBenchmarks.allFlagState:·gc.time avgt 100 1612.000 ms

Benchmark Mode Cnt Score Error Units
LDClientEvaluationBenchmarks.allFlagState avgt 100 396.184 ± 3.652 ns/op
LDClientEvaluationBenchmarks.allFlagState:·gc.alloc.rate avgt 100 2558.533 ± 22.781 MB/sec
LDClientEvaluationBenchmarks.allFlagState:·gc.alloc.rate.norm avgt 100 1594.840 ± 0.004 B/op
LDClientEvaluationBenchmarks.allFlagState:·gc.churn.G1_Eden_Space avgt 100 2441.965 ± 34.891 MB/sec
LDClientEvaluationBenchmarks.allFlagState:·gc.churn.G1_Eden_Space.norm avgt 100 1521.985 ± 14.795 B/op
LDClientEvaluationBenchmarks.allFlagState:·gc.churn.G1_Survivor_Space avgt 100 0.014 ± 0.001 MB/sec
LDClientEvaluationBenchmarks.allFlagState:·gc.churn.G1_Survivor_Space.norm avgt 100 0.008 ± 0.001 B/op
LDClientEvaluationBenchmarks.allFlagState:·gc.count avgt 100 1898.000 counts
LDClientEvaluationBenchmarks.allFlagState:·gc.time avgt 100 1659.000 ms

Main
Benchmark Mode Cnt Score Error Units
LDClientEvaluationBenchmarks.allFlagState avgt 100 407.267 ± 3.380 ns/op
LDClientEvaluationBenchmarks.allFlagState:·gc.alloc.rate avgt 100 2517.584 ± 19.629 MB/sec
LDClientEvaluationBenchmarks.allFlagState:·gc.alloc.rate.norm avgt 100 1613.513 ± 0.003 B/op
LDClientEvaluationBenchmarks.allFlagState:·gc.churn.G1_Eden_Space avgt 100 2394.218 ± 30.173 MB/sec
LDClientEvaluationBenchmarks.allFlagState:·gc.churn.G1_Eden_Space.norm avgt 100 1534.405 ± 14.654 B/op
LDClientEvaluationBenchmarks.allFlagState:·gc.churn.G1_Survivor_Space avgt 100 0.014 ± 0.001 MB/sec
LDClientEvaluationBenchmarks.allFlagState:·gc.churn.G1_Survivor_Space.norm avgt 100 0.009 ± 0.001 B/op
LDClientEvaluationBenchmarks.allFlagState:·gc.count avgt 100 1910.000 counts
LDClientEvaluationBenchmarks.allFlagState:·gc.time avgt 100 1629.000 ms

Benchmark Mode Cnt Score Error Units
LDClientEvaluationBenchmarks.allFlagState avgt 100 391.854 ± 4.775 ns/op
LDClientEvaluationBenchmarks.allFlagState:·gc.alloc.rate avgt 100 2588.506 ± 29.915 MB/sec
LDClientEvaluationBenchmarks.allFlagState:·gc.alloc.rate.norm avgt 100 1594.841 ± 0.003 B/op
LDClientEvaluationBenchmarks.allFlagState:·gc.churn.G1_Eden_Space avgt 100 2509.273 ± 39.834 MB/sec
LDClientEvaluationBenchmarks.allFlagState:·gc.churn.G1_Eden_Space.norm avgt 100 1545.881 ± 15.164 B/op
LDClientEvaluationBenchmarks.allFlagState:·gc.churn.G1_Survivor_Space avgt 100 0.014 ± 0.001 MB/sec
LDClientEvaluationBenchmarks.allFlagState:·gc.churn.G1_Survivor_Space.norm avgt 100 0.009 ± 0.001 B/op
LDClientEvaluationBenchmarks.allFlagState:·gc.count avgt 100 1930.000 counts
LDClientEvaluationBenchmarks.allFlagState:·gc.time avgt 100 1664.000 ms

@tanderson-ld tanderson-ld merged commit e9ea4df into main Oct 24, 2024
12 checks passed
@tanderson-ld tanderson-ld deleted the ta/sdk-687/prereq-events-support branch October 24, 2024 21:15
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Merged
tanderson-ld pushed a commit that referenced this pull request Oct 24, 2024
@github-actions
chore(main): release 7.6.0 (#40)
8fe5eef 
🤖 I have created a release *beep* *boop*
---


##
[7.6.0](7.5.0...7.6.0)
(2024-10-24)


### Features

* Adds support for client side prerequisite events.
([#39](#39))
([e9ea4df](e9ea4df))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-launchdarkly louis-launchdarkly louis-launchdarkly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanderson-ld @louis-launchdarkly